update eslint and eslint-plugin -no-unsafe-innerhtml, use babel for parsing

RESOLVED FIXED in FxOS-S7 (18Sep)

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: freddyb, Assigned: freddyb)

Tracking

unspecified
FxOS-S7 (18Sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This improvement is twofold:

We need to update eslint, since we are using quite an old version, that by the way changes how testing works. Thus we needed to modify the no-unsafe-innerhtml plugin.

In other news, we've found a few bugs and made some enhancement to the no-unsafe-innerhtml plugin that founds more security bugs, removes some false positives and comes with less problems on new-ish syntax.

On top of all that, stuff in Gaia started to use ES7 features that are not yet supported by the eslint builtin js parser, called espree. So I suggest we move to babel-eslint, as babel is much more cutting edge when it comes to ecmascript support.
Comment on attachment 8659239 [details] [review]
[gaia] mozfreddyb:update-eslint-2015-09-10 > mozilla-b2g:master

Eslint-task is green on try for this patch. Can you review, Julien?
Attachment #8659239 - Flags: review?(felash)
See Also: → 1196956
Comment on attachment 8659239 [details] [review]
[gaia] mozfreddyb:update-eslint-2015-09-10 > mozilla-b2g:master

go for it, r=me :)

Thanks and sorry for the delay !
Attachment #8659239 - Flags: review?(felash) → review+
https://github.com/mozilla-b2g/gaia/commit/cbd96906fb53baeb5a004f75f5dfab6877210e98
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.