1203536 - [RTL Locales] new non-e10s window button does not fit in palette

Status: NEW

(Firefox :: Toolbars and Customization, defect)

Description

[magicp]

Attachment: new-non-e10s-button-in-palette.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150909004021

Steps to reproduce:

1. Run Firefox 42.0a2 or 43.0a1 Arabic version.
2. Open Customize.
3. Drag and drop new non-e10s window button in palette.


Actual results:

New non-e10s window button does not fit in palette. Please refer to attached image.


Expected results:

New non-e10s window button should be fit in palette with RTL locales.

This issue will be fixed the following...

chrome://browser/content/browser.css (line:1156)

toolbarpaletteitem[place="palette"] {
  width: 10em;
  height: calc(50px + 1.5em);
  margin-bottom: 5px;
- overflow: hidden;
+ overflow: visible;
+ vertical-align: top;
  display: inline-block;
}

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

we're not shipping this

Comment 2

[magicp]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #1)
> we're not shipping this

Who is the person in charge of this issue? Thanks.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

What issue? We're not shipping this beyond aurora

Comment 4

[magicp]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #3)
> What issue? We're not shipping this beyond aurora

Could you confirm the following Aurora and Nightly? Should I teach you how to install or reproduce step by step?

https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora-l10n/firefox-42.0a2.ar.win32.installer.exe
[App]
Vendor=Mozilla
Name=Firefox
RemotingName=firefox-dev
CodeName=FirefoxDeveloperEdition
Version=42.0a2
BuildID=20150916004013
SourceRepository=https://hg.mozilla.org/releases/mozilla-aurora
SourceStamp=7484c6088282
ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}

https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/firefox-43.0a1.ar.win32.installer.exe
[App]
Vendor=Mozilla
Name=Firefox
RemotingName=firefox
CodeName=Nightly
Version=43.0a1
BuildID=20150916030203
SourceRepository=https://hg.mozilla.org/mozilla-central
SourceStamp=3e8dde8f8c174cce2c0b65c951808f88e35d1875
ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}

Comment 5

[magicp]

I am awaiting your reply for Comment 4.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to magicp from comment #4)
> (In reply to Brad Lassey [:blassey] (use needinfo?) from comment #3)
> > What issue? We're not shipping this beyond aurora
> 
> Could you confirm the following Aurora and Nightly? 
No, because I don't care. As I stated before, this button isn't going to ship beyond Aurora so therefore we don't care about how it localizes. Just to clarify though, the tracking-e10s- means that the team that is working to ship e10s to our release audience will not put time into fixing this. That does not preclude you or someone else form fixing it though.

> Should I teach you how to install or reproduce step by step?
No, I don't think that will be necessary, see above as to why.

Comment 7

[magicp]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #6)
> (In reply to magicp from comment #4)
> > (In reply to Brad Lassey [:blassey] (use needinfo?) from comment #3)
> > > What issue? We're not shipping this beyond aurora
> > 
> > Could you confirm the following Aurora and Nightly? 
> No, because I don't care. As I stated before, this button isn't going to
> ship beyond Aurora so therefore we don't care about how it localizes. Just
> to clarify though, the tracking-e10s- means that the team that is working to
> ship e10s to our release audience will not put time into fixing this. That
> does not preclude you or someone else form fixing it though.
> 
> > Should I teach you how to install or reproduce step by step?
> No, I don't think that will be necessary, see above as to why.

Your first comment "we're not shipping this" has no clear explanation. I don't know you're what team and what are you responsible for. So my understanding was "Mozilla is not shipping the new non-e10s window button".

What happen!? :\

As I wrote in expected results, this is a layout issue (not e10s and low priority for you). If it is correct, could you assign this bug to a person in charge? Because this issue has a possibility also for other buttons. Thank you in advance.