Tweak handling of compiler warnings in mozglue

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 years ago
This gets rid of the ALLOW_COMPILER_WARNINGS=True in mozglue's moz.build file.
Assignee

Comment 1

4 years ago
Attachment #8659278 - Flags: review?(mh+mozilla)
Comment on attachment 8659278 [details] [diff] [review]
Tweak handling of compiler warnings in mozglue

Review of attachment 8659278 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/build/moz.build
@@ +50,5 @@
> +        if CONFIG['_MSC_VER']:
> +            # Suppress the following warning: "nonstandard extension used:
> +            # '`anonymous-namespace'::DllBlockSet::Write' uses SEH and 'lock'
> +            # has destructor"
> +            SOURCES['WindowsDllBlocklist.cpp'].flags += ['-wd4509']

I'm not sure what MSVC does in that case, but to be on the safe side, I'd rather actually fix the warning than risk the lock never being released if an exception does occur.
Replacing AutoCriticalSection with its explicit equivalent (see implementation in xpcom/base/nsWindowsHelpers.h) at the beginning and the end of the function should fix it.
Attachment #8659278 - Flags: review?(mh+mozilla)
Assignee

Comment 4

4 years ago
New patch that actually fixes the error, as requested.
Attachment #8659630 - Flags: review?(mh+mozilla)
Assignee

Updated

4 years ago
Attachment #8659278 - Attachment is obsolete: true
Attachment #8659630 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/28402d7deddb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.