1203596 - Remove userconfig file from shared B2G cache

Status: RESOLVED FIXED

(Taskcluster :: General, defect, P1)

Comment 1

[Wander Lairson Costa]

Attachment: Remove .userconfig after run build.sh. r=jlund,garndt

If we keep the userconfig file inside B2G shared cache, it may cause
build bustage in other branches. As we don't what build steps are set up
in the config files, we safely add and remove the .userconfig file at
each call to build.sh.

Comment 2

[Wander Lairson Costa]

Comment on attachment 8659474 [details] [diff] [review]
Remove .userconfig after run build.sh. r=jlund,garndt

https://treeherder.allizom.org/#/jobs?repo=try&revision=d0d4f745044c

Comment 3

[Greg Arndt [:garndt]]

Comment on attachment 8659474 [details] [diff] [review]
Remove .userconfig after run build.sh. r=jlund,garndt

remove r?.  Spoke to wcosta on IRC about this.  At a high level I like what this will do, but trust others with reviewing the mozharness changes.  Not sure what else this might affect.

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8659474 [details] [diff] [review]
Remove .userconfig after run build.sh. r=jlund,garndt

Review of attachment 8659474 [details] [diff] [review]:
-----------------------------------------------------------------

neat! while I like the use of context/with statement, we might be able to leverage a mh builtin to simplify this. Mozharness has listener methods that can hook on to certain places within a script run.

Specifically: PostScriptRun[1]

You can see an example of that being used here[2].

So in this case, you could probably shrink this patch to a couple lines. Something like:
    @PostScriptRun
    def _remove_userconfig(self):
        os.remove(userconfig_path)

I'm not very familiar with b2g_build.py. I'm assuming this userconfig .file be created (if not present) at the time we need it on the next task run?

r- for now, but if you don't think my idea is better or doable, let's have a chat and see if this patch is the only option :)

[1] https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/script.py#1361
[2] https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#1976

Comment 5

[Wander Lairson Costa]

Attachment: Remove .userconfig after run build.sh. r=jlund

If we keep the userconfig file inside B2G shared cache, it may
cause build bustage in other branches.

Comment 6

[Wander Lairson Costa]

Comment on attachment 8660096 [details] [diff] [review]
Remove .userconfig after run build.sh. r=jlund

https://treeherder.allizom.org/#/jobs?repo=try&revision=734b04ffa7e6

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8660096 [details] [diff] [review]
Remove .userconfig after run build.sh. r=jlund

Review of attachment 8660096 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the orange is unrelated?

Comment 8

[Wander Lairson Costa]

(In reply to Jordan Lund (:jlund) from comment #7)
> Comment on attachment 8660096 [details] [diff] [review]
> Remove .userconfig after run build.sh. r=jlund
> 
> Review of attachment 8660096 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I assume the orange is unrelated?

orange?

Comment 9

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #7)
> Comment on attachment 8660096 [details] [diff] [review]
> Remove .userconfig after run build.sh. r=jlund
> 
> Review of attachment 8660096 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I assume the orange is unrelated?

the orange jobs (non green letters):
https://treeherder.allizom.org/#/jobs?repo=try&revision=734b04ffa7e6

Comment 10

[Wander Lairson Costa]

(In reply to Jordan Lund (:jlund) from comment #9)
> (In reply to Jordan Lund (:jlund) from comment #7)
> > Comment on attachment 8660096 [details] [diff] [review]
> > Remove .userconfig after run build.sh. r=jlund
> > 
> > Review of attachment 8660096 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I assume the orange is unrelated?
> 
> the orange jobs (non green letters):
> https://treeherder.allizom.org/#/jobs?repo=try&revision=734b04ffa7e6

Oh, yeah, they are unrelated.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/d39277479422

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d39277479422