1203688 - Users cant login via oauth

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)

Description

[Dale Harvey (:daleharvey)]

Looks like a recent change to bugzilla means the oauth type flow is now broken

Comment 1

[Dale Harvey (:daleharvey)]

Hey Byron, I didnt notice any being announced, are there any changes to this flow?

Comment 2

[Dale Harvey (:daleharvey)]

It fails with 

Auth delegation received an HTTP response other than 200 OK from auth consumer. Code: 404

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Right, the auth delegation sends a post request now. Let me dig up the docs on that.

Comment 4

[Dale Harvey (:daleharvey)]

Hrm a POST request is pretty problematic, it means that it isnt possible to build a bugzilla client as a static application without a web server. I luckily havent already got rid of the bzlite web server so I will probably be able to live with it, but I was planning to move it to hosting on gh-pages. I assume a bunch of people who want to use the bugzilla api would also like to build their applications as static apps without a web server.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

GET requests are more problematic as the api keys will show up in server logs. Bug 1175643 is the change that introduced this. The dogs are not up on read the docs yet, I'll get that sorted out right now.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Here's how it works now. https://bmo.readthedocs.org/en/latest/integrating/auth-delegation.html

I'm closing out this bug. You can catch me on irc most of the time if you have any issues!

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Heh, I realize this is not a bugzilla bug. my apologies.

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/bzlite/pull/42

This has been pushed to https://bzlite-staging.herokuapp.com/ to test (you can only use credentials @ https://github.com/mozilla-b2g/bzlite#running-bugzilla-lite to login, personal logins wont work)

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 8660303 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/42

Adding Dylan since it looks like dietrich is busy, Dylan if you could take a quick look at this would be appreciated

Comment 10

[Dale Harvey (:daleharvey)]

Comment on attachment 8660303 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/42

I will get this reviewed before merging damnit :)

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8660303 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/42

It looks sane to me.

We had a B-Team work week last week, so nobody was really available to review it. Sorry about that. :)

r=dylan

Comment 12

[Dale Harvey (:daleharvey)]

No bother, thanks for the review

https://github.com/mozilla-b2g/bzlite/commit/1923e9c0a934acf2657ff9f138697410c3b88410

Comment 13

[Dietrich Ayala (:dietrich)]

Comment on attachment 8660303 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/42

Canceling review request since already landed - so maybe doesn't matter, but I had a few questions on the PR.