1203692 - Audit logs (particularly for any URLs we might leak)

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stephan Leroux [:sleroux]]

We need to make sure that we are not leaking any URLs or sensitive data in our app logging.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

On a production build we are logging full details of your Sync secrets:

Oct  4 20:56:43 Stefans-iPhone-6 Client[437] <Warning>: onLogin: {"customizeSync":false,"sessionToken":"xxx","keyFetchToken":"xxx","verified":true,"unwrapBKey":"xxx","email":"[e-mail]","uid":"xxx","verifiedCanLinkAccount":true}

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1119

Remove verbose logging from FxAContentViewController

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8669492 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1119

Wouldn't say no to a quick 1.0.2.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Merged https://github.com/mozilla/firefox-ios/pull/1119

Leaving this bug open in case we find more logging issues.

Comment 5

[Richard Newman [:rnewman]]

I'll finish this.

Comment 6

[Stephan Leroux [:sleroux]]

Here's what I've found that we're logging that is questionable:

Recording of URLs in log files on disk for every non-private tab visit:
Profile#L221 - log.debug("Recording visit for \(url) with type \(v).")

Recording of URLs in log files on disk when removing/adding bookmarks:
SQLiteBookmarks#L283 - log.debug("Removing bookmark \(url).")

Logging of synced tab urls to disk:
TabSynchronizer#L84 log.debug("\(remotes)")


Creating tabs from tab records:
TabSynchronizer#L41 log.debug("Sending tabs JSON \(tabsJSON.toString(true))")

Logging DB secret:
2015-10-14 11:50:12.660 [Debug] [BrowserDB.swift:47] init(filename:secretKey:files:) > Creating db: /private/var/mobile/Containers/Shared/AppGroup/3EBD981A-58BA-4A0A-959B-F0B0FFFEC8FC/profile.profile/logins.db with secret = Optional("njF81qBBMRi4oCKHHD/lANF2UH2cr1mynvpu6KcwKiJxSuBbe0Kbag+GO1MD3Y1QQJqsGAMYUEAa9YWBfpFU6CFlehHBP20rYnMYXdzxpV7IQvnqQ3dvThhOMqegCDpQsVpRKEJmUl/crsguP4QhxAtqosnpu8za6xlSgcd4io0nR8x8x8MAzD47q4My6h1KJ1ObcIGQ4/llGLu5kSHg0FlM8HvIHc9fdE8vavcO9uOixRJ940Lzg0IgPRevUcUJrPHd10OFzxD6j7mag90ffj3c5ePql68g2Zc7sxrE6+HsX8mhSM5u/b+gpLo37dp2Q2HNNAP67bclJc+PVULnJw==")

Comment 7

[Richard Newman [:rnewman]]

I have a couple of commits coming for those.

Comment 8

[Richard Newman [:rnewman]]

(In reply to Stephan Leroux [:sleroux] from comment #6)

> Logging DB secret:

Note that we only do that for developer builds, precisely so we can debug by poking the DB.

Comment 9

[Richard Newman [:rnewman]]

Commits are at the end of https://github.com/mozilla/firefox-ios/pull/1146.

Comment 10

[Richard Newman [:rnewman]]

4155dea

Comment 11

[Richard Newman [:rnewman]]

2015-10-14 15:38:29.987 [Debug] [SQLiteLogins.swift:217] getLoginsForProtectionSpace > Looking for login: https://bugzilla.mozilla.org

Comment 12

[Richard Newman [:rnewman]]

Attachment: Another PR

Stealing this back for a final pass.

Comment 13

[Richard Newman [:rnewman]]

2dfaff7