1203716 - Size/render the log-line container correctly with long pre-formatted lines

Status: RESOLVED DUPLICATE of bug 1315808

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

A follow-up to bug 1201235, if possible we should calculate the log line container correctly with long lines, now that they are pre-formatted.

Currently, the container stops short.

The grey/white lines and the log-line container should encompass the entire line length.

(related property)
https://github.com/mozilla/treeherder/blob/master/ui/css/logviewer.css#L92

Comment 1

[Jonathan French (:jfrench)]

Attachment: longLines

Per screen grab.

Comment 2

[Gabriel Machado [:goma]]

Hey. I'd like to work on this bug :)

Comment 3

[Jonathan French (:jfrench)]

Thanks :goma! Feel free to work on this after bug 1203698 is fixed, unless this has to be fixed first to support it.

Comment 4

[Gabriel Machado [:goma]]

Hey :jfrench.
Just a small question about this bug.
It seems that I have to get the log-container width value by Script, and then pass this value to the log-line for both error lines, and log-selected lines, right?
Or is there a way to do it by CSS??

Thanks

Comment 5

[Jonathan French (:jfrench)]

It's possible there might be a css solution. I did a google search just now for 'pre text outside container' and there seem to be quite a few discussions on it. I'll let you dig around. If not go ahead locally test the alternate solution you're proposing; if it's identical, loads as quickly, resizes correctly, go ahead and open a PR and :camd can review it :)

Keep in mind, each time you load a new log "chunk" when scrolling, the loaded line lengths may differ. That may impact your the first proposed solution, I'm not sure. But it is a test case to check.

Comment 7

[Ed Morley [:emorley]]

Hi Gabriel, are you still working on this?
No problem if not, just wanted to update the status of this bug :-)

Comment 8

[Gabriel Machado [:goma]]

Hi emorley.
I've not been working on this bug as I've been quite busy for the last months.
I'll have free time again in two weeks though(finally \o/ ) and I'm planning to back to contribute with the ateam again.
So, basically. I can work on this bug again in two weeks.

Comment 9

[Ed Morley [:emorley]]

I believe the new unified log viewer handles this case fine.
If there are still issues, they'll need to be filed against it instead:
https://github.com/taskcluster/unified-logviewer/issues