1203728 - test_sms_auto_save_draft.py: AttributeError: 'Thread' object has no attribute 'tap'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Nicholas Nelson [:NicholasN]]

Description:
This test is failing in the daily non-smoke bitbar run, and failed 5/5 adhoc tests as well. Based on the screenshot and traceback, it appears that the test fails to re-open the saved draft in the Messages app. Running this test locally did not reproduce the issue, nor was I able to reproduce it manually.

Steps:
1. Update flame device to 20150910030223.
2. Open Messages app.
3. Type some text into the body of the message.
4. Close the app.
5. Re-open the app and select the auto-saved draft.

Actual Result:
Test fails to re-open saved draft thread.

Expected Result:
Test completes successfully.

Link to Jenkins report:
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.1/411/HTML_Report/

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.1/.env/local/lib/python2.7/site-packages/marionette_client-0.17-py2.7.egg/marionette/marionette_test.py", line 296, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.1/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_auto_save_draft.py", line 54, in test_sms_auto_save_draft
new_message = messages.draft_threads[0].tap()
AttributeError: 'Thread' object has no attribute 'tap'

Comment 1

[Martijn Wargers (dead)]

This is a regression from bug 1196717. It looks like this should be messages.draft_threads[0].open() instead of messages.draft_threads[0].tap().

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1203728 > mozilla-b2g:master

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8659876 [details] [review]
[gaia] JohanLorenzo:bug-1203728 > mozilla-b2g:master

Sorry for this small nit. I did some checking to make sure no tap() method remained. It turned out to be a bit longer than I expected, as tap() is used mostly everywhere in our code base, and PyCharm is not smart enough to map a method returned in a python property.

I manually checked the calls on the properties `threads` and `draft_threads`, and see if the tests did a call on tap(), there was only this one.

Comment 4

[John Dorlus [:Silne30]]

Comment on attachment 8659876 [details] [review]
[gaia] JohanLorenzo:bug-1203728 > mozilla-b2g:master

Looks good to me.

Comment 5

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/b2171fba020538ab96890a3db4813a1e8e4f399a