1203736 - Return errors from H264::DecodeSPS

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Ralph Giles (:rillian)]

H264::DecodeSPS asserts on a null argument, but otherwise returns a bool which is checked. Convert the assert into a false return so we can gtest it.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Convert H264::DecodeSPS assert to error return.

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8659565 [details] [diff] [review]
Convert H264::DecodeSPS assert to error return.

Review of attachment 8659565 [details] [diff] [review]:
-----------------------------------------------------------------

this now unnecessary following bug 1186716 ; but I guess it can't hurt.

Comment 3

[Jean-Yves Avenard [:jya]]

there's much more to do to check on errors however ; so this bug isn't fixed.

Following every read on the bitreader we need to check that we had the information and that it made sense.

right now all of those will be mixed and instead return true even though the SPS was invalid

Comment 4

[Ralph Giles (:rillian)]

Yes, setting the bitreader flag is bug 1203205. This is just a quick bit I saw along the way.

Comment 5

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01d3a641203f970a446948634b9dbb6f36fb5908
Bug 1203736 - Convert H264::DecodeSPS assert to error return. r=jya

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01d3a641203f