Closed Bug 1203736 Opened 4 years ago Closed 4 years ago

Return errors from H264::DecodeSPS

Categories

(Core :: Audio/Video: Playback, defect, P2)

42 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

H264::DecodeSPS asserts on a null argument, but otherwise returns a bool which is checked. Convert the assert into a false return so we can gtest it.
Comment on attachment 8659565 [details] [diff] [review]
Convert H264::DecodeSPS assert to error return.

Review of attachment 8659565 [details] [diff] [review]:
-----------------------------------------------------------------

this now unnecessary following bug 1186716 ; but I guess it can't hurt.
Attachment #8659565 - Flags: review?(jyavenard) → review+
there's much more to do to check on errors however ; so this bug isn't fixed.

Following every read on the bitreader we need to check that we had the information and that it made sense.

right now all of those will be mixed and instead return true even though the SPS was invalid
Yes, setting the bitreader flag is bug 1203205. This is just a quick bit I saw along the way.
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/01d3a641203f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.