1203743 - Windows and Linux Dev Edition theme bottom border on #navigator-toolbox isn't using theme colors

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

This background [0] (`#navigator-toolbox::after { background: var(--chrome-navigator-toolbox-separator-color); }`) isn't as specific as the rules used in windows and linux setting the background color with: `#navigator-toolbox:-moz-lwtheme::after`. [1][2]

This makes the 'border' on the bottom of the nav toolbox look too dark, especially on the light DE theme.

[0]: https://dxr.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f/browser/themes/shared/devedition.inc.css#160
[1]: https://dxr.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f/browser/themes/windows/browser.css#122
[2]: https://dxr.mozilla.org/mozilla-central/rev/dd2a1d737a64d9a3f23714ec5cc623ec8933b51f/browser/themes/linux/browser.css#63

Comment 1

[:Gijs (he/him)]

On top of this, on win8 we make the background of the #browser-panel transparent and so Windows' background color (orange, in my case) shines through the border. Not nice.

Comment 2

[Rakhi(:rakhisharma)]

Attachment: Bug 1203743 - Windows and Linux Dev Edition theme bottom border on #navigator-toolbox isn't using theme colors r= Gijs.

Review commit: https://reviewboard.mozilla.org/r/58304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58304/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8760903 [details]
Bug 1203743 - Windows and Linux Dev Edition theme bottom border on #navigator-toolbox isn't using theme colors r= Gijs.

https://reviewboard.mozilla.org/r/58304/#review55192

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81bdc81c20b6
Windows and Linux Dev Edition theme bottom border on #navigator-toolbox isn't using theme colors r= Gijs.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81bdc81c20b6