1203759 - Review spark code analysing xpinstall.signatures.required pref

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Dave Townsend [:mossop]]

I wrote an IPython notebook for checking how many users across different channels have xpinstall.signatures.required set to false. I think it's right but I have some strange results. According to the results there is not one single person on aurora or beta who have set it to false. That seems unlikely so either there is something wrong with my code or there is something I'm not understanding about telemetry.

Bug 1196890 added the pref to telemetry, it's been on nightly for a while but less time for the other branches. We also just flipped the default on aurora/beta so the notebook attempts to figure out the default value of the pref based on the build id.

Can you look at my code and help me understand what might be going on here?

Comment 1

[Roberto Agostino Vitillo (:rvitillo)]

There doens't seem to be anything wrong with your notebook and I can confirm that the pref is missing, see [1].

[1] https://gist.github.com/vitillo/49e60f08ff6c7705949b

Comment 2

[Dave Townsend [:mossop]]

So this is strange. I have developers using aurora telling me that have flipped this pref yet it doesn't show up anywhere in the data. Do aurora builds only include a subset of the prefs in the ping they send?

I have developers using aurora telling me they have flipped this pref. One of them copied their settings from about:telemetry, it includes the addonCompatibilityCheckEnabled property added in bug 1196890 but not the value of xpinstall.signatures.required which they had changed.

Comment 3

[Vladan Djeric (:vladan)]

You never added xpinstall.signatures.required to the watchlist on Aurora and Beta:

https://bugzilla.mozilla.org/show_bug.cgi?id=1196890#c10

Comment 4

[Dave Townsend [:mossop]]

Damn, looks like something went wrong in the uplift :(