Closed Bug 1203772 Opened 4 years ago Closed 4 years ago

[Window management] Home button will stop functioning and status bar icons will turn white when home button is pressed while an app is opening from card view

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.2 affected, b2g-master verified)

VERIFIED FIXED
FxOS-S8 (02Oct)
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: AdamA, Assigned: etienne)

References

()

Details

(Whiteboard: [2.5-Daily-Testing][Spark])

Attachments

(3 files)

Attached file logcat
Description:
If the user is in card view and presses an app to return to it then quickly taps the home button then the home button will not function when the app is open and the status bar icons will turn white. Users can get out of the app by entering card view again.

Repro Steps:
1) Update a Aries to 20150909215207
2) Open an app
3) Long press home button to enter card view
4) Tap on an app to return to it
5) While app is transitioning tap the home button
6) Observe status bar icons and home button functionality

Actual:
The status bar icons turn white and the home button stips functioning

Expected:
It is expected that the home button always brings user to the home screen and that the status bar icons contrast with the status bar

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150909215207
Gaia: 47459eead04385e22f967012b824f5abdddcfb7c
Gecko: dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 10/10
See attached: Video, logcat
This issue DOES occur on Flame 2.5 and Flame 2.2.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150910030223
Gaia: 47459eead04385e22f967012b824f5abdddcfb7c
Gecko: dd2a1d737a64d9a3f23714ec5cc623ec8933b51f
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.2 [Full Flash]
BuildID: 20150909183023
Gaia: 7a427e0f8aa6c185a9e22358006b97c19435ca4a
Gecko: 0d9c46d01861
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The status bar icons turn white and the home button stops functioning
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
[Blocking Requested - why for this release]:

Not a regression but a bad issue so nominating this 2.5?
blocking-b2g: --- → 2.5?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Blocks 2.5 with P2 priority
blocking-b2g: 2.5? → 2.5+
Priority: -- → P2
Assignee: nobody → etienne
Comment on attachment 8661840 [details] [review]
[gaia] etiennesegonzac:bug-1203772 > mozilla-b2g:master

Before this patch we ended up calling exitToApp twice (and scheduling 2 timeouts to call app.open then wait for the _opened event)... which was causing a bad race.

I can see how ideally we'd want to end up on the homescreen, but until we straighten up this part of the code I'd rather not fix the race condition with race-y code and just safely ignore the event during the transition to the app.
Attachment #8661840 - Flags: review?(sfoster)
Comment on attachment 8661840 [details] [review]
[gaia] etiennesegonzac:bug-1203772 > mozilla-b2g:master

Looks good, thanks
Attachment #8661840 - Flags: review?(sfoster) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/e67d319d0854e32e23210784eb9c4e1b8a025adb
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
This bug has been verified as pass on latest build of Flame v2.5 and Aries v2.5 by the STR in comment 0.

Actual results: The home button always brings user to the home screen and the status bar icons display correctly.

See attachment: Verified_Aries_v2.5.3gp
Reproduce rate: 0/10

Device: Aries KK 2.5(Pass)
Build ID               20150921174442
Gaia Revision          29991414eb94b6baa1ec2e63fdb4f6dfae05fb01
Gaia Date              2015-09-21 09:27:10
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/197af2fb7e29ff8e4b3b6ced723b6172e954e17d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150921.170449
Firmware Date          Mon Sep 21 17:04:57 UTC 2015
Bootloader             s1

Device: Flame KK 2.5(Pass)
Build ID               20150921073455
Gaia Revision          2d370fa35c1a0ee2a637e3772c0843586a5f96c9
Gaia Date              2015-09-21 02:41:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/039a8490891595736b16a3ccb17f025f4dcf13eb
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150921.112037
Firmware Date          Mon Sep 21 11:20:52 EDT 2015
Fireware Date          v18D v4
Bootloader             L1TC000118D0
Attached video Verified_Aries_v2.5.3gp
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.