1203794 - Commit table overflows when window size is not "large enough"

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot

My guess is it's a regression from adding the hg links on the left. See attached screenshot.

Comment 1

[Dan Minor [:dminor]]

d'oh

Comment 2

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: Commit table overflows when window size is not "large enough" (bug 1203794) r?mcote

mozreview: Commit table overflows when window size is not "large enough" (bug 1203794) r?mcote

We need to increase the minimum size of the commits table to account for the
width of the Hg column.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 8660035 [details]
MozReview Request: mozreview: Commit table overflows when window size is not "large enough" (bug 1203794) r?mcote

https://reviewboard.mozilla.org/r/19061/#review17269

::: pylib/mozreview/mozreview/static/mozreview/css/commits.less:29
(Diff revision 1)
> -  min-width: 600px;
> +  min-width: 618px;

The cell appears to be 29 pixels wide for me. Should min-width be larger?  I'll admit that this is CSS and CSS confuses me, though.

Comment 4

[Dan Minor [:dminor]]

https://reviewboard.mozilla.org/r/19061/#review17269

> The cell appears to be 29 pixels wide for me. Should min-width be larger?  I'll admit that this is CSS and CSS confuses me, though.

We set the min-width of the Hg column to be 18 pixels here [1] so I took the old min-width of the table and added the min-width of the new column to get 618. It fixed the bug as reported for me, but I'm also far from a CSS expert :)

[1] https://dxr.mozilla.org/hgcustom_version-control-tools/source/pylib/mozreview/mozreview/static/mozreview/css/commits.less#48

Comment 5

[Mark Côté [:mcote]]

https://reviewboard.mozilla.org/r/19061/#review17269

> We set the min-width of the Hg column to be 18 pixels here [1] so I took the old min-width of the table and added the min-width of the new column to get 618. It fixed the bug as reported for me, but I'm also far from a CSS expert :)
> 
> [1] https://dxr.mozilla.org/hgcustom_version-control-tools/source/pylib/mozreview/mozreview/static/mozreview/css/commits.less#48

Okay, if it fixes the problem, good enough. :)

Comment 6

[Mark Côté [:mcote]]

Comment on attachment 8660035 [details]
MozReview Request: mozreview: Commit table overflows when window size is not "large enough" (bug 1203794) r?mcote

https://reviewboard.mozilla.org/r/19061/#review17277

Comment 7

[Dan Minor [:dminor]]

Thanks!
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0507d61f76d6