Fix loop condition in BluetoothPbapManager::PackPropertiesMask

RESOLVED FIXED in Firefox 43, Firefox OS v2.2r

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ben Tian (inactive), Assigned: Ben Tian (inactive))

Tracking

unspecified
FxOS-S7 (18Sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed, b2g-master affected)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
The condition is incorrect as I gave wrong comment in bug 1180554 comment 3. This bug is to fix it.
(Assignee)

Comment 1

3 years ago
Created attachment 8659700 [details] [diff] [review]
[m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang

Also revise some comments.
Assignee: nobody → btian
Attachment #8659700 - Flags: review?(shuang)
(Assignee)

Comment 2

3 years ago
Set blocking-b2g:2.2r+ since this bug impacts on 2.2r bluetooth feature PBAP.
blocking-b2g: --- → 2.2r+
(Assignee)

Updated

3 years ago
Blocks: 1203821
Comment on attachment 8659700 [details] [diff] [review]
[m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang

Review of attachment 8659700 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, what kinds of tests do you perform?
Attachment #8659700 - Flags: review?(shuang) → review+
(Assignee)

Updated

3 years ago
status-b2g-v2.2r: --- → affected
status-b2g-master: --- → affected
https://hg.mozilla.org/mozilla-central/rev/295432fe3668
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
(Assignee)

Comment 6

3 years ago
Created attachment 8660525 [details] [diff] [review]
[2.2r] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang
Attachment #8659700 - Attachment is obsolete: true
(Assignee)

Comment 7

3 years ago
Comment on attachment 8659700 [details] [diff] [review]
[m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang

Undo the mis-tag.
Attachment #8659700 - Attachment is obsolete: false
(Assignee)

Updated

3 years ago
Attachment #8659700 - Attachment description: Patch 1 (v1): Fix loop condition in BluetoothPbapManager::PackPropertiesMask → [m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang
You need to log in before you can comment on or make changes to this bug.