Closed
Bug 1203819
Opened 10 years ago
Closed 10 years ago
Fix loop condition in BluetoothPbapManager::PackPropertiesMask
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed, b2g-master affected)
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
Attachments
(2 files)
|
2.43 KB,
patch
|
shawnjohnjr
:
review+
|
Details | Diff | Splinter Review |
|
2.20 KB,
patch
|
Details | Diff | Splinter Review |
The condition is incorrect as I gave wrong comment in bug 1180554 comment 3. This bug is to fix it.
|
Assignee | |
Comment 1•10 years ago
|
||
Also revise some comments.
Assignee: nobody → btian
Attachment #8659700 -
Flags: review?(shuang)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Set blocking-b2g:2.2r+ since this bug impacts on 2.2r bluetooth feature PBAP.
blocking-b2g: --- → 2.2r+
Comment on attachment 8659700 [details] [diff] [review]
[m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang
Review of attachment 8659700 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, what kinds of tests do you perform?
Attachment #8659700 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Updated•10 years ago
|
status-b2g-v2.2r:
--- → affected
status-b2g-master:
--- → affected
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8659700 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8659700 [details] [diff] [review]
[m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang
Undo the mis-tag.
Attachment #8659700 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8659700 -
Attachment description: Patch 1 (v1): Fix loop condition in BluetoothPbapManager::PackPropertiesMask → [m-c] Patch 1: Fix loop condition in BluetoothPbapManager::PackPropertiesMask, r=shuang
|
|
||
Comment 8•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•