Closed Bug 1203828 Opened 4 years ago Closed 4 years ago

Marionette test, test_mobile_data_ipv6.js, doesn't really test the v4 or v6 ip addresses

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S7 (18Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

I expect test_mobile_data_ipv6.js will fail on emulator-x86-kk since emulator-x86-kk doesn't cherry-pick the patches of bug 978071 yet, but it pass. It seems it doesn't really test the v4 or v6 ip addresses well.
Blocks: 978071
Assignee: nobody → echen
Bug 1203828 - Let test_mobile_data_ipv6.js really test the v4 or v6 ip addresses
We should give false as an initialValue, otherwise reduce() use the first element of array as the initialValue and cause the reduce() always returns true.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/Reduce
Comment on attachment 8659720 [details]
MozReview Request: Bug 1203828 - Let test_mobile_data_ipv6.js really test the v4 or v6 ip addresses

Bug 1203828 - Let test_mobile_data_ipv6.js really test the v4 or v6 ip addresses
Attachment #8659720 - Flags: review?(jjong)
Comment on attachment 8659720 [details]
MozReview Request: Bug 1203828 - Let test_mobile_data_ipv6.js really test the v4 or v6 ip addresses

https://reviewboard.mozilla.org/r/19011/#review16885

Thanks for this.
Attachment #8659720 - Flags: review?(jjong) → review+
Blocks: 1183002
No longer blocks: 978071
https://hg.mozilla.org/mozilla-central/rev/e51bd9252028
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.