120383 - make Category at the top of the prefs listing unclickable

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[sairuh (rarely reading bugmail)]

spun of off bug 118154.

is there any way to make the Category label in the prefs dialog non-clickable?
it doesn't sort, after all...

Comment 1

[sairuh (rarely reading bugmail)]

jan, feel to reassign, if you wish...

Comment 2

[Jan Varga [:janv]]

accepting

Comment 3

[[e-mail]]

Attachment: Proposed patch

This just restricts the clicking effect to sortDirectionIndicator columns.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 67721 [details] [diff] [review]
Proposed patch

neil, your patch has some issues.
e.g. thread and flagged column in thread pane is not clickable, clicking on
column picker enlarges it etc.

Comment 5

[Jan Varga [:janv]]

I think, it would be better to just hide column header.
Moving to 1.1.alpha for now

Comment 6

[sairuh (rarely reading bugmail)]

i wouldn't mind if the column header were hidden. also compare with the Mailnews
acct settings window, where there is no column header.

Comment 7

[[e-mail]]

Works in my skin, I'll look at classic and modern again. Patch bitrotted anyway.

Comment 8

[[e-mail]]

Attachment: Updated patch

Comment 9

[[e-mail]]

Attachment: Looks like sortDirectionIndicator is deprecated

Comment 10

[Jan Varga [:janv]]

Nominating for buffy.
We might want accept Neil's patch or hide column header entirely.

Comment 11

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 12

[Jan Varga [:janv]]

Ok, here is my plan:
Take Neil's patch and also replace column header with <label> like it was before

Neil, I've just tried your patch, looks good.
Although I found a little bug, click on column picker in folder pane, I don't
know why column picker gets wider.
Other column pickers work ok.

Comment 13

[Jan Varga [:janv]]

Comment on attachment 90225 [details] [diff] [review]
Looks like sortDirectionIndicator is deprecated

I figured out where was the problem

>-.treecol-image:hover:active {
>+.treecol-image[sort]:hover:active,
>+tree[enableColumnDrag] > treecols > .treecol-image:hover:active {
>   padding: 1px 1px 0px 2px;
> }
> 

adding |treecolpicker| fixes the problem

However, I don't think this patch is ready.
What about trees which use own view implementation, so they don't use |sort|
attribute
to indicate sorting.

Comment 14

[Jan Varga [:janv]]

Attachment: new patch

This patch just hides tree col header and replaces it with a label

Comment 15

[Jan Varga [:janv]]

sairuh, could you review the last patch ?
thanks

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 93164 [details] [diff] [review]
new patch

sr=bzbarsky

Comment 17

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 93164 [details] [diff] [review]
new patch

r=sicking

Comment 18

[Jan Varga [:janv]]

Checked in.

Comment 19

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.09.16.08 builds.

Comment 20

[sairuh (rarely reading bugmail)]

really verifying...