Closed Bug 1203834 Opened 4 years ago Closed 4 years ago

Fix's rapl's handling of unsupported power domains

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

The "gpu" and "ram" domains aren't supported by all platforms. rapl has a
special constant |kUnsupported_j| to represent this on Linux, but I
accidentally have a minus sign in front of it in several places, which means
that instead of printing "n/a" for unsupported planes we always print "1.0".

I think this happened because I used to hardwire -1 in there and then I later
changed it to a constant but forgot to remove the minus signs.

It sure would be nice to have automated testing for this stuff, but I don't see
how to do it.
Attachment #8659726 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/44d375dd46bb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.