Closed Bug 1203898 Opened 4 years ago Closed 4 years ago
[browser] Re-skin Firefox Account sign in process for TV
46 bytes, text/x-github-pull-request
|Details | Review|
Once the Firefox Account sign in flow is brought to TV, it should be re-skin according to visual design.
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices]
Hi Peko, Could you provide visual spec for re-skin? Thanks!
Hi, there are some modification after review. I can upload the layout for you if you want. I will provide visual spec by the end of the week. Thanks
Hi Login/out spec is ready, please check here https://drive.google.com/folderview?id=0B4K8q1qWmtAvWWduYzFycmJuLWs&usp=sharing I am working on other pages and going to update asap Thanks
Hi, Here is the latest spec. https://drive.google.com/open?id=0B4K8q1qWmtAvZHJBalY3U3pyWTQ Thanks
Comment on attachment 8676110 [details] [review] [gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master Hi Yi-fan, please help me to review. This patch re-skin fxa-email and fxa-enter-password page for firefox account signin process. Thanks.
Attachment #8676110 - Flags: review?(yliao)
Comment on attachment 8676110 [details] [review] [gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master * The 'x' in the clear email input button is not centered. * Please file a follow up bug and ni Tori to discuss if we need to enable a user to cancel the sign in flow. * Please file a follow up bug to remove the login successful page.
Attachment #8676110 - Flags: review?(yliao) → review+
Thank for the review. Merge in master: https://github.com/mozilla-b2g/gaia/commit/f90ba707414828062e8d0013662c5ae386d10e44
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Have you created follow up bugs? I couldn't find them on the dependency tree. Thanks!
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.