Closed Bug 1203898 Opened 8 years ago Closed 8 years ago

[browser] Re-skin Firefox Account sign in process for TV

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(feature-b2g:2.5+)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)
Project Flags:
feature-b2g 2.5+

People

(Reporter: yifan, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(1 file)

[gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
Details | Review 
Once the Firefox Account sign in flow is brought to TV, it should be re-skin according to visual design.
No longer blocks: 1194091, 1194092, 1194094, 1194096, 1194097, 1194098, 1194104
Depends on: 1202360
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices]
Depends on: 1207481
No longer depends on: 1207481
Depends on: 1207483
No longer depends on: 1207483
See Also: → 1207483
See Also: → 1207481
See Also: 1207483 →
See Also: 1207481 →
Depends on: 1207488
No longer depends on: 1207488
feature-b2g: --- → 2.5+
Hi Peko,
Could you provide visual spec for re-skin? Thanks!
Flags: needinfo?(pchen)
Hi, there are some modification after review.
I can upload the layout for you if you want.
I will provide visual spec by the end of the week.
Thanks
Flags: needinfo?(pchen)
Target Milestone: --- → FxOS-S10 (30Oct)
Assignee: nobody → dhuang
Hi 
Login/out spec is ready, please check here
https://drive.google.com/folderview?id=0B4K8q1qWmtAvWWduYzFycmJuLWs&usp=sharing
I am working on other pages and going to update asap
Thanks
Flags: needinfo?(dhuang)
got it!
Flags: needinfo?(dhuang)
Priority: -- → P2
Comment on attachment 8676110 [details] [review]
[gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master

Hi Yi-fan, please help me to review. This patch re-skin fxa-email and fxa-enter-password page for firefox account signin process. Thanks.
Attachment #8676110 - Flags: review?(yliao)
Comment on attachment 8676110 [details] [review]
[gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master

* The 'x' in the clear email input button is not centered.
* Please file a follow up bug and ni Tori to discuss if we need to enable a user to cancel the sign in flow.
* Please file a follow up bug to remove the login successful page.
Attachment #8676110 - Flags: review?(yliao) → review+
Blocks: 1215169
Thank for the review.
Merge in master:
https://github.com/mozilla-b2g/gaia/commit/f90ba707414828062e8d0013662c5ae386d10e44
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Have you created follow up bugs? I couldn't find them on the dependency tree. Thanks!
Flags: needinfo?(dhuang)
Bug 1216854 and Bug 1216855 !
Flags: needinfo?(dhuang)
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.