Closed
Bug 1203898
Opened 8 years ago
Closed 8 years ago
[browser] Re-skin Firefox Account sign in process for TV
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P2)
Tracking
(feature-b2g:2.5+)
People
(Reporter: yifan, Assigned: danhuang)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick])
Attachments
(1 file)
Once the Firefox Account sign in flow is brought to TV, it should be re-skin according to visual design.
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•8 years ago
|
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices]
Reporter | ||
Updated•8 years ago
|
Updated•8 years ago
|
feature-b2g: --- → 2.5+
Comment 1•8 years ago
|
||
Hi Peko, Could you provide visual spec for re-skin? Thanks!
Flags: needinfo?(pchen)
Comment 2•8 years ago
|
||
Hi, there are some modification after review. I can upload the layout for you if you want. I will provide visual spec by the end of the week. Thanks
Flags: needinfo?(pchen)
Updated•8 years ago
|
Target Milestone: --- → FxOS-S10 (30Oct)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dhuang
Comment 3•8 years ago
|
||
Hi Login/out spec is ready, please check here https://drive.google.com/folderview?id=0B4K8q1qWmtAvWWduYzFycmJuLWs&usp=sharing I am working on other pages and going to update asap Thanks
Comment 4•8 years ago
|
||
Hi, Here is the latest spec. https://drive.google.com/open?id=0B4K8q1qWmtAvZHJBalY3U3pyWTQ Thanks
Updated•8 years ago
|
Flags: needinfo?(dhuang)
Updated•8 years ago
|
Priority: -- → P2
Comment 6•8 years ago
|
||
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8676110 [details] [review] [gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master Hi Yi-fan, please help me to review. This patch re-skin fxa-email and fxa-enter-password page for firefox account signin process. Thanks.
Attachment #8676110 -
Flags: review?(yliao)
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8676110 [details] [review] [gaia] danhuang1202:1203898_fx_account_signin_reskin > mozilla-b2g:master * The 'x' in the clear email input button is not centered. * Please file a follow up bug and ni Tori to discuss if we need to enable a user to cancel the sign in flow. * Please file a follow up bug to remove the login successful page.
Attachment #8676110 -
Flags: review?(yliao) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Thank for the review. Merge in master: https://github.com/mozilla-b2g/gaia/commit/f90ba707414828062e8d0013662c5ae386d10e44
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•8 years ago
|
||
Have you created follow up bugs? I couldn't find them on the dependency tree. Thanks!
Flags: needinfo?(dhuang)
Reporter | ||
Updated•8 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•