Missing tests in syntax-error-illegal-character.js files

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: anba, Assigned: arai)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

js/src/jit-test/basic/syntax-error-illegal-character.js

- There is no call to the test_syntax() function in this file.


js/src/jit-test/asm.js/syntax-error-illegal-character.js

- This file is empty except for the |jit-test| line.


http://hg.mozilla.org/mozilla-central/rev/4f87d8225c7a
Thank you for catching this.

js/src/jit-test/asm.js/syntax-error-illegal-character.js should be removed, all tests there were merged to js/src/jit-test/lib/syntax.js.

I'll prepare patch shortly.
Now Reflect.parse requires module option to parse export/import, so added it to test for export/import.
Assignee: nobody → arai.unmht
Attachment #8660002 - Flags: review?(jwalden+bmo)
I overlooked those changes while rebasing.
Moved to jit-test/tests/parser as others are there.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07c0b5130452
Attachment #8660004 - Flags: review?(jwalden+bmo)
Removed test_no_* function and changed to pass options directly :)
Attachment #8660002 - Attachment is obsolete: true
Attachment #8660002 - Flags: review?(jwalden+bmo)
Attachment #8661459 - Flags: review?(jwalden+bmo)
Attachment #8661459 - Flags: review?(jwalden+bmo) → review+
Attachment #8660004 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/d3dad76b9080
https://hg.mozilla.org/mozilla-central/rev/48876dcd455e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.