1203963 - Missing tests in syntax-error-illegal-character.js files

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

js/src/jit-test/basic/syntax-error-illegal-character.js

- There is no call to the test_syntax() function in this file.


js/src/jit-test/asm.js/syntax-error-illegal-character.js

- This file is empty except for the |jit-test| line.


http://hg.mozilla.org/mozilla-central/rev/4f87d8225c7a

Comment 1

[Tooru Fujisawa [:arai]]

Thank you for catching this.

js/src/jit-test/asm.js/syntax-error-illegal-character.js should be removed, all tests there were merged to js/src/jit-test/lib/syntax.js.

I'll prepare patch shortly.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 0: Support Reflect.parse with module in parser test.

Now Reflect.parse requires module option to parse export/import, so added it to test for export/import.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Call test_syntax in syntax-error-illegal-character.js.

I overlooked those changes while rebasing.
Moved to jit-test/tests/parser as others are there.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=07c0b5130452

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Part 0: Support Reflect.parse with module in parser test.

Removed test_no_* function and changed to pass options directly :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3dad76b9080
https://hg.mozilla.org/integration/mozilla-inbound/rev/48876dcd455e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d3dad76b9080
https://hg.mozilla.org/mozilla-central/rev/48876dcd455e