1204007 - Cross out permission icons in the control center when they have been blocked

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Brian Grinstead [:bgrins]]

Icons in the permissions view in the control center should be crossed out if they are blocked.  See https://mozilla.invisionapp.com/share/DM3XGA6YE#/screens/96290112.

Comment 1

[[e-mail]]

could you help find the right person to provide permission icons?

Comment 2

[Ash Grigas]

(In reply to Fred Lin [:gasolin] from comment #1)
> could you help find the right person to provide permission icons?

yes, its bryan bell on the UX team

Comment 3

[bbell]

(In reply to Fred Lin [:gasolin] from comment #1)
> could you help find the right person to provide permission icons?


the icons you need can be found in here 

https://www.dropbox.com/sh/nscav5ttkzv5apy/AABKbOBzO2w1GkCxH_xycJkNa?dl=0

Comment 4

[[e-mail]]

should work after bug 1274480

Comment 5

[[e-mail]]

As :paolo addressed in bug 1193006 comment 71, we need to take svg icon from 16x16 then transform and make it fit to 32x32 

In this issue 32x32 svg does not contain `blocked` series of icons. 

Could you help to bring them to 32x32?

Comment 6

[[e-mail]]

Attachment: blocked.png

Here's the screenshot when all SitePermissions set blocked as default

Comment 7

[[e-mail]]

Attachment: Bug 1204007 - show blocked icon in control center when they have been blocked;

Review commit: https://reviewboard.mozilla.org/r/61178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61178/

Comment 8

[[e-mail]]

Since popup icon does not contain `blocked-icon` version, I pick the same popup icon.

Comment 9

[:Paolo Amadini]

Comment on attachment 8766175 [details]
Bug 1204007 - show blocked icon in control center when they have been blocked;

https://reviewboard.mozilla.org/r/61178/#review58124

Looks good! In the meantime, just today in bug 1206252 Johann created a version of the blocked SVG icons generated procedurally. I've asked him to post it to this bug so you can just "hg pull" the MozReview changeset (with the command indicated near "Pull:" on the left of the MozReview interface) and then "hg rebase" your changeset on top of it.

::: browser/base/content/browser.js:7241
(Diff revision 1)
> -      "identity-popup-permission-icon " + aPermission.id + "-icon");
> +      "identity-popup-permission-icon " + aPermission.id + state + "-icon");
>  

Add "blocked" as a separate class. Then...

::: browser/themes/shared/notification-icons.inc.css:79
(Diff revision 1)
> +.camera-blocked-icon,
>  .geo-icon,
> +.geo-blocked-icon,
>  .indexedDB-icon,

...you don't need to add these extra entries here, and...

::: browser/themes/shared/notification-icons.inc.css:123
(Diff revision 1)
> +.desktop-notification-blocked-icon {
> +  list-style-image: url(chrome://browser/skin/glyphs.svg#desktop-notification-blocked);
> +}
> +

...you can use .desktop-notification-icon.blocked as a selector to change the list-style-image.

::: browser/themes/shared/notification-icons.inc.css:225
(Diff revision 1)
> +.popup-icon,
> +.popup-blocked-icon {

And you won't need the double selector here. Maybe add a comment for why this icon doesn't have a "blocked" version?

Comment 10

[Johann Hofmann [:johannh]]

Attachment: Bug 1204007 - Part 1: Add blocked permission icons to glyphs.svg.

Review commit: https://reviewboard.mozilla.org/r/61274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61274/

Comment 11

[Johann Hofmann [:johannh]]

There you go!

Comment 12

[Johann Hofmann [:johannh]]

Comment on attachment 8766293 [details]
Bug 1204007 - Part 1: Add blocked permission icons to glyphs.svg.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61274/diff/1-2/

Comment 13

[:Paolo Amadini]

Comment on attachment 8766293 [details]
Bug 1204007 - Part 1: Add blocked permission icons to glyphs.svg.

https://reviewboard.mozilla.org/r/61274/#review58138

Comment 14

[:Paolo Amadini]

(In reply to Fred Lin [:gasolin] from comment #8)
> Since popup icon does not contain `blocked-icon` version, I pick the same
> popup icon.

Actually, I missed this comment earlier. I think the reason why we don't show a strikethrough on this icon is that it has a "block" sign in it already, so this is what we should say in the comment.

Comment 15

[[e-mail]]

Attachment: blocksnap

Thanks for feedback! Here's the screenshot based on johann's svg modification

Comment 16

[[e-mail]]

Comment on attachment 8766175 [details]
Bug 1204007 - show blocked icon in control center when they have been blocked;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61178/diff/1-2/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a667fecb7613
Part 1 - Add blocked permission icons to glyphs.svg. r=paolo
https://hg.mozilla.org/integration/fx-team/rev/050c0ad48c78
Part 2 - Cross out permission icons in the Control Center when they have been blocked. r=paolo

Comment 18

[:Paolo Amadini]

Note that I've fixed the missing "popup" icon in part 1 before landing it.

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a667fecb7613
https://hg.mozilla.org/mozilla-central/rev/050c0ad48c78

Comment 20

[[e-mail]]

thanks!

Comment 21

[Paul Silaghi, QA [:pauly]]

Looks good, verified fixed on FX 50.0a1 (2016-07-07) Win 7, Ubuntu 14.04, OS X 10.11.

Anyway, I still have 2 observations: 
1. Can't we somehow refresh live the control center when toggling between allow/block? Now you need to dismiss it and open again in order to see the permission icons changes
2. The blocked location permission on mac looks just like an arrow - http://i.imgur.com/NUhdRNd.png. Can't we use the round location icon from win/linux instead?

Comment 22

[[e-mail]]

1. The UI change is worked in bug 1203292, the right side dropdown selector will be replaced to the simpler one, which doesn't need present the live icon change.

2. relay the 2nd question in comment 21 to designer