If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

lw-themes (Personas) will be disabled after each extension update or installation

VERIFIED FIXED in Firefox 43

Status

()

Toolkit
Add-ons Manager
--
major
VERIFIED FIXED
2 years ago
2 months ago

People

(Reporter: Virtual, Assigned: mossop)

Tracking

({nightly-community, regression})

43 Branch
mozilla43
nightly-community, regression
Points:
---

Firefox Tracking Flags

(firefox42 unaffected, firefox43+ verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

[Tracking Requested - why for this release]: Regression
Component: Theme → Add-ons Manager
Product: Firefox → Toolkit
(Assignee)

Comment 1

2 years ago
Almost certainly from bug 1192921
Assignee: nobody → dtownsend
Blocks: 1192921
(Assignee)

Updated

2 years ago
Keywords: regressionwindow-wanted
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1204045
(Assignee)

Comment 3

2 years ago
Created attachment 8660008 [details]
MozReview Request: Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

When a lightweight theme is active the default theme is the selected skin but
the default theme's addon object is marked as inactive (to deal with the horror
of only allowing the user to select a single theme through the UI).

During startup we should only switch back to the default theme if there is a
non-default skin selected that we didn't see.
Attachment #8660008 - Flags: review?(rhelmer)
(Assignee)

Updated

2 years ago
Attachment #8660008 - Attachment is obsolete: true
Attachment #8660008 - Flags: review?(rhelmer)
(Assignee)

Comment 4

2 years ago
Created attachment 8660015 [details]
MozReview Request: Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

When a lightweight theme is active the default theme is the selected skin but
the default theme's addon object is marked as inactive (to deal with the horror
of only allowing the user to select a single theme through the UI).

During startup we should only switch back to the default theme if there is a
non-default skin selected that we didn't see.
Attachment #8660015 - Flags: review?(rhelmer)
Status: NEW → ASSIGNED
Attachment #8660015 - Flags: review?(rhelmer) → review+
Comment on attachment 8660015 [details]
MozReview Request: Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

https://reviewboard.mozilla.org/r/19057/#review17041

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/edc2651ffc25
https://hg.mozilla.org/mozilla-central/rev/edc2651ffc25
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Status: RESOLVED → VERIFIED
status-firefox43: fixed → verified
Tracking after the fix just in case.
tracking-firefox43: ? → +
Keywords: nightly-community
QA Contact: Virtual
You need to log in before you can comment on or make changes to this bug.