Closed Bug 1204012 Opened 5 years ago Closed 5 years ago

lw-themes (Personas) will be disabled after each extension update or installation

Categories

(Toolkit :: Add-ons Manager, defect)

43 Branch
defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla43
Tracking Status
firefox42 --- unaffected
firefox43 + verified

People

(Reporter: Virtual, Assigned: mossop)

References

Details

(Keywords: nightly-community, regression)

Attachments

(1 file, 1 obsolete file)

[Tracking Requested - why for this release]: Regression
Component: Theme → Add-ons Manager
Product: Firefox → Toolkit
Almost certainly from bug 1192921
Assignee: nobody → dtownsend
Blocks: 1192921
OS: Windows 7 → All
Hardware: x86_64 → All
Duplicate of this bug: 1204045
Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

When a lightweight theme is active the default theme is the selected skin but
the default theme's addon object is marked as inactive (to deal with the horror
of only allowing the user to select a single theme through the UI).

During startup we should only switch back to the default theme if there is a
non-default skin selected that we didn't see.
Attachment #8660008 - Flags: review?(rhelmer)
Attachment #8660008 - Attachment is obsolete: true
Attachment #8660008 - Flags: review?(rhelmer)
Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

When a lightweight theme is active the default theme is the selected skin but
the default theme's addon object is marked as inactive (to deal with the horror
of only allowing the user to select a single theme through the UI).

During startup we should only switch back to the default theme if there is a
non-default skin selected that we didn't see.
Attachment #8660015 - Flags: review?(rhelmer)
Attachment #8660015 - Flags: review?(rhelmer) → review+
Comment on attachment 8660015 [details]
MozReview Request: Bug 1204012: Lightweight themes are disabled if any add-ons are detected or modified during startup. r?rhelmer

https://reviewboard.mozilla.org/r/19057/#review17041
https://hg.mozilla.org/mozilla-central/rev/edc2651ffc25
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Tracking after the fix just in case.
You need to log in before you can comment on or make changes to this bug.