1204036 - Disable Async Plugin Init for FF41 Release

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Based on QE recommendation and known issues in this area, we should pref "dom.ipc.plugins.asyncInit.enabled" to false by default in FF41.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Aaron, would you be able to create a patch and nominate for uplift before we gtb 41 RC on Monday? Thanks!

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

[Tracking Requested - why for this release]: Async plugin init still has issues and may not be release ready. Let's disable for 41.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked so we keep an eye on this one until it lands and any possible regressions.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Vladan, also n-i'ing for your help here to get the patch landed asap as I gtb 41 RC in an hour or so.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Disabling

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]: none

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8660813 [details] [diff] [review]
Disabling

Self reviewing since it's just a pref toggle.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8660813 [details] [diff] [review]
Disabling

[Triage Comment] Thanks Aaron for providing a patch promptly. Approving for uplift to moz-release so this is included in 41 RC build.

Comment 8

[Robert Kaiser]

I don't understand this request. It it disabled for all plugins except a short whitelist anyhow already from what I understand. Do we still have issues with the whitelisted plugins as well? If so, can you point me to the respective bugs?

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-release/rev/4d6a54f1317f

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Also landing to beta at Ritu's request: https://hg.mozilla.org/releases/mozilla-beta/rev/5e9b2a323145

Comment 11

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

This was covered by Plug-in compatibility testing performed in Firefox 41 RC build 1 (https://docs.google.com/spreadsheets/d/1rQS6fGgzlWHfk3zDbe-6gK5ESirvPCI6YcESlpg2Sk0/edit#gid=1224410939). No new issues were encountered, so marking this as verified.