1204074 - more_info_button getter breaks if label isn't ascii

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Axel Hecht [:Pike]]

Attachment: use unicode template string instead of plain str

The fix from bug 1203581 doesn't handle unicode labels right, this is in easy fix.

What puzzles me is that we have passing tests for russian and zh-TW with this bug, and that shouldn't happen.

Is there a way that the automation is picking up either the German or the English build? Where would a bug for that go.

I personally lean on the side of first trying to get the automation runs to fail, and then fix the failure.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8660065 [details] [diff] [review]
use unicode template string instead of plain str

Review of attachment 8660065 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I was thinking to better use :last-child here for the CSS selector but once developers change their mind again, our tests would be broken. So that solution is fine.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed patch after updating the commit message on master:
https://github.com/mozilla/firefox-ui-tests/commit/6e055a4727bcef4385f59b0e623a5944fc4fd593

Thank you Axel for providing the patch! I will file a follow-up bug to get at least a locale tested via Travis CI.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The underlying control center patch got landed on aurora yesterday. So I cherry-picked my patch from 1203581 for mozilla-aurora. That said we also have to land this patch on mozilla-aurora.

https://github.com/mozilla/firefox-ui-tests/commit/117f3c16c440fbf1e99325c8471b83cfee5c6eea (aurora)