TryToolsMixin does not work with Buildbot jobs triggered through BBB

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: armenzg, Unassigned)

Tracking

unspecified

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The problem is the same as to what I am facing for read-buildbot-config (bug 1203085).
The changes object is empty, hence, we can't find the commit message.

Unlike in bug 1203085, I could find the info I needed from properties.json.

Nevertheless, I can grab the info from here:
https://hg.mozilla.org/try/json-pushes?changeset=71e69424094d&tipsonly=1&version=2&full=1

I can use the new get() method to grab the info:
https://hg.mozilla.org/try/rev/57c3bbe8cbcd

[1] https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/KrVnqlYAR7msaUtyxHTWWg/0/public/properties.json

Failing code:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/try_tools.py#31

You can see the jobs in here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=71e69424094d&filter-searchStr=Ubuntu%20VM%2012.04%20x64%20try%20opt%20test%20mochitest-1

The error:
0:41:45    ERROR - Exception during post-action for download-and-extract: Traceback (most recent call last):
10:41:45    ERROR -   File "/builds/slave/test/scripts/mozharness/base/script.py", line 1651, in run_action
10:41:45    ERROR -     method(action, success=success and self.return_code == 0)
10:41:45    ERROR -   File "/builds/slave/test/scripts/mozharness/mozilla/testing/try_tools.py", line 63, in _set_extra_try_arguments
10:41:45    ERROR -     msg = self._extract_try_message()
10:41:45    ERROR -   File "/builds/slave/test/scripts/mozharness/mozilla/testing/try_tools.py", line 31, in _extract_try_message
10:41:45    ERROR -     msg = self.buildbot_config['sourcestamp']['changes'][-1]['comments']
10:41:45    ERROR - IndexError: list index out of range
(Reporter)

Comment 1

2 years ago
Created attachment 8660084 [details] [diff] [review]
[wip] grab message from pushlog if not available in Buildbot Changes
(Reporter)

Comment 2

2 years ago
It worked!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eec8ef6361f

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/03233057f1e6
https://hg.mozilla.org/mozilla-central/rev/03233057f1e6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.