Closed Bug 1204102 Opened 5 years ago Closed 5 years ago

Unified build breakage in UbiNodeCensus files

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jolesen, Assigned: jolesen)

References

Details

Attachments

(1 file, 1 obsolete file)

The UbiNodeCensus source files are missing #includes, so they cause the unified build to break when clustering boundaries move.
Attachment #8660119 - Flags: review?(sphink) → review+
Keywords: checkin-needed
Hi, this failed to apply:

applying Bug-1204102---Add-missing-includes-and-namespaces-.patch
patching file js/src/vm/UbiNodeCensus.cpp
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file js/src/vm/UbiNodeCensus.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1204102---Add-missing-includes-and-namespaces-.patch

could you take a look, thanks!
Flags: needinfo?(jolesen)
Keywords: checkin-needed
The namespace line which caused a merge conflict was already added by a different commit.
Attachment #8660119 - Attachment is obsolete: true
Flags: needinfo?(jolesen)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d5eaaf9ba224
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1206187
You need to log in before you can comment on or make changes to this bug.