Unified build breakage in UbiNodeCensus files

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jolesen, Assigned: jolesen)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The UbiNodeCensus source files are missing #includes, so they cause the unified build to break when clustering boundaries move.
(Assignee)

Comment 1

3 years ago
Created attachment 8660119 [details] [diff] [review]
Add missing includes and namespaces to UbiNodeCensus files
Attachment #8660119 - Flags: review?(sphink)
Attachment #8660119 - Flags: review?(sphink) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Hi, this failed to apply:

applying Bug-1204102---Add-missing-includes-and-namespaces-.patch
patching file js/src/vm/UbiNodeCensus.cpp
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file js/src/vm/UbiNodeCensus.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1204102---Add-missing-includes-and-namespaces-.patch

could you take a look, thanks!
Flags: needinfo?(jolesen)
Keywords: checkin-needed
(Assignee)

Comment 3

3 years ago
Created attachment 8660931 [details] [diff] [review]
Add missing includes to UbiNodeCensus files.

The namespace line which caused a merge conflict was already added by a different commit.
Attachment #8660119 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Flags: needinfo?(jolesen)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d5eaaf9ba224
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Assignee)

Updated

3 years ago
Blocks: 1206187
You need to log in before you can comment on or make changes to this bug.