Closed
Bug 1204102
Opened 10 years ago
Closed 10 years ago
Unified build breakage in UbiNodeCensus files
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: jolesen, Assigned: jolesen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.63 KB,
patch
|
Details | Diff | Splinter Review |
The UbiNodeCensus source files are missing #includes, so they cause the unified build to break when clustering boundaries move.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8660119 -
Flags: review?(sphink)
|
||
Updated•10 years ago
|
Attachment #8660119 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 2•10 years ago
|
||
Hi, this failed to apply:
applying Bug-1204102---Add-missing-includes-and-namespaces-.patch
patching file js/src/vm/UbiNodeCensus.cpp
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file js/src/vm/UbiNodeCensus.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1204102---Add-missing-includes-and-namespaces-.patch
could you take a look, thanks!
Flags: needinfo?(jolesen)
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•10 years ago
|
||
The namespace line which caused a merge conflict was already added by a different commit.
Attachment #8660119 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(jolesen)
Keywords: checkin-needed
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•