Closed Bug 1204120 Opened 4 years ago Closed 4 years ago

Add talos support to |mach try|

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jgraham, Unassigned)

References

Details

Attachments

(1 file)

With the implementation that uses REMAINDER_ARGS to find extra things to pass to mozharness '-t none' considers -t to be an argument to pass through and 'none' to be a test path. Which is not ideal. So why not just support this.
Bug 1204120 - Allow passing talos arguments to |mach try|.

This has the side effect that passing -t none doesn't result
in bare -t being passed (because "none" is interpreted as a
test path).
Attachment #8660269 - Flags: review?(cmanchester)
Comment on attachment 8660269 [details]
MozReview Request: Bug 1204120 - Allow passing talos arguments to |mach try|.

https://reviewboard.mozilla.org/r/19083/#review17111

::: testing/tools/autotry/autotry.py:27
(Diff revision 1)
> -                        help='Build types to run (d for debug, o for optimized)')
> +                        help='Talos suites to run in their entirety')

just 'Talos suites to run'
Attachment #8660269 - Flags: review?(cmanchester) → review+
Comment on attachment 8660269 [details]
MozReview Request: Bug 1204120 - Allow passing talos arguments to |mach try|.

Bug 1204120 - Allow passing talos arguments to |mach try|.

This has the side effect that passing -t none doesn't result
in bare -t being passed (because "none" is interpreted as a
test path).
sorry had to back this out since one of the changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=14640968&repo=mozilla-inbound
backed out for the test bustage in bug 1193215
Flags: needinfo?(james)
Flags: needinfo?(james)
https://hg.mozilla.org/mozilla-central/rev/208546659971
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.