1204120 - Add talos support to |mach try|

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[James Graham [:jgraham]]

With the implementation that uses REMAINDER_ARGS to find extra things to pass to mozharness '-t none' considers -t to be an argument to pass through and 'none' to be a test path. Which is not ideal. So why not just support this.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1204120 - Allow passing talos arguments to |mach try|.

Bug 1204120 - Allow passing talos arguments to |mach try|.

This has the side effect that passing -t none doesn't result
in bare -t being passed (because "none" is interpreted as a
test path).

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8660269 [details]
MozReview Request: Bug 1204120 - Allow passing talos arguments to |mach try|.

https://reviewboard.mozilla.org/r/19083/#review17111

::: testing/tools/autotry/autotry.py:27
(Diff revision 1)
> -                        help='Build types to run (d for debug, o for optimized)')
> +                        help='Talos suites to run in their entirety')

just 'Talos suites to run'

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8660269 [details]
MozReview Request: Bug 1204120 - Allow passing talos arguments to |mach try|.

Bug 1204120 - Allow passing talos arguments to |mach try|.

This has the side effect that passing -t none doesn't result
in bare -t being passed (because "none" is interpreted as a
test path).

Comment 4

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b4c42f82452

Comment 5

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ad176f1c4b

Comment 6

[James Graham [:jgraham]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=488486282efe

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9748ff0d2836

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out since one of the changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=14640968&repo=mozilla-inbound

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3000fca0fc88

Comment 10

[Carsten Book [:Tomcat]]

backed out for the test bustage in bug 1193215

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/208546659971

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/208546659971