Closed Bug 1204134 Opened 5 years ago Closed 5 years ago

Disallow warnings in config/moz.build

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

These were necessary when I introduced ALLOW_COMPILER_WARNINGS in bug 1198334,
but something must have changed subsequently, because try server is all green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2e1e0ead6e3
Attachment #8660176 - Flags: review?(mh+mozilla)
Comment on attachment 8660176 [details] [diff] [review]
Disallow warnings in config/moz.build

Review of attachment 8660176 [details] [diff] [review]:
-----------------------------------------------------------------

Could be bug 1198226
Attachment #8660176 - Flags: review?(mh+mozilla) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1af6f6b7db1b for the nasty surprise that SpiderMonkey builds do have warnings in config/
Oh, now I remember -- I hit the same problem in bug 1198334, which prompted me to file bug 1200072: try pushes don't exactly match mozilla-inbound pushes, and this patch is ok on try but causes SM(e) build failures on inbound.
https://hg.mozilla.org/mozilla-central/rev/7fedb2bf7fcb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.