1204134 - Disallow warnings in config/moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nicholas Nethercote [inactive]]

These were necessary when I introduced ALLOW_COMPILER_WARNINGS in bug 1198334,
but something must have changed subsequently, because try server is all green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2e1e0ead6e3

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Disallow warnings in config/moz.build

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8660176 [details] [diff] [review]
Disallow warnings in config/moz.build

Review of attachment 8660176 [details] [diff] [review]:
-----------------------------------------------------------------

Could be bug 1198226

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eea9adc2d1a5

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1af6f6b7db1b for the nasty surprise that SpiderMonkey builds do have warnings in config/

Comment 5

[Nicholas Nethercote [inactive]]

Oh, now I remember -- I hit the same problem in bug 1198334, which prompted me to file bug 1200072: try pushes don't exactly match mozilla-inbound pushes, and this patch is ok on try but causes SM(e) build failures on inbound.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fedb2bf7fcb

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7fedb2bf7fcb