Closed Bug 1204170 Opened 4 years ago Closed 4 years ago

Fix icns file for b2g graphene builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file)

There's a missing icns file since bug 1193227 which messes up the packaging for Graphene builds.  Graphene is the runtime for browser.html and Horizon.

Problem introduced here:
https://github.com/mozilla/gecko-projects/commit/9b473303d

So because of this icns file:
https://hg.mozilla.org/mozilla-central/file/19f806034f67/b2g/app/Makefile.in#l62

It should match here:
https://hg.mozilla.org/mozilla-central/file/19f806034f67/b2g/installer/package-manifest.in#l35

Fixing shortly to make the last 2 links reference the same .icns file always.
Attached patch bug1204170.diffSplinter Review
Attachment #8660224 - Flags: review?(spohl.mozilla.bugs)
Attachment #8660224 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/8a316d4c6458
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.