IonMonkey: MIPS32: Inline RelocationIterator

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

Trunk
mozilla43
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8660250 [details] [diff] [review]
0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch

Inline RelocationIterator in Assembler::TraceJumpRelocations.
Attachment #8660250 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8660250 [details] [diff] [review]
0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch

Review of attachment 8660250 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/Assembler-mips32.cpp
@@ +7,5 @@
>  #include "jit/mips32/Assembler-mips32.h"
>  
> +#include "mozilla/DebugOnly.h"
> +
> +using mozilla::DebugOnly;

nit: DebugOnly does not seems required by this patch.
Attachment #8660250 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Comment 2

3 years ago
(In reply to Nicolas B. Pierron [:nbp] from comment #1)
> Comment on attachment 8660250 [details] [diff] [review]
> 0001-IonMonkey-MIPS32-Inline-RelocationIterator.patch
> 
> Review of attachment 8660250 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/jit/mips32/Assembler-mips32.cpp
> @@ +7,5 @@
> >  #include "jit/mips32/Assembler-mips32.h"
> >  
> > +#include "mozilla/DebugOnly.h"
> > +
> > +using mozilla::DebugOnly;
> 
> nit: DebugOnly does not seems required by this patch.

Yes, I fix a latent build issue by the way. ;)
https://hg.mozilla.org/mozilla-central/rev/862295d7d82a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.