Closed Bug 1204191 Opened 5 years ago Closed 5 years ago

IonMonkey: MIPS: Split shareable code to mips-shared in Lowering-mips32

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(1 file)

Bug 1194139, part 5: Lowering-mips.
Attachment #8660253 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8660253 [details] [diff] [review]
Lowering-mips.patch

Review of attachment 8660253 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/Lowering-mips-shared.cpp
@@ +78,1 @@
>                                              MDefinition* lhs, MDefinition* rhs);

nit: Keep these lines properly indented with the first argument of the previous line.

And do this for all signatures of function in the patch too.

::: js/src/jit/mips32/Lowering-mips32.cpp
@@ +8,1 @@
>  #include "jit/mips32/Assembler-mips32.h"

nit: Add a newline above this one, to separate the header which is associated with this file from all other headers.
Attachment #8660253 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/8e4da0532d8f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.