1204191 - IonMonkey: MIPS: Split shareable code to mips-shared in Lowering-mips32

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Attachment: Lowering-mips.patch

Bug 1194139, part 5: Lowering-mips.

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8660253 [details] [diff] [review]
Lowering-mips.patch

Review of attachment 8660253 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/Lowering-mips-shared.cpp
@@ +78,1 @@
>                                              MDefinition* lhs, MDefinition* rhs);

nit: Keep these lines properly indented with the first argument of the previous line.

And do this for all signatures of function in the patch too.

::: js/src/jit/mips32/Lowering-mips32.cpp
@@ +8,1 @@
>  #include "jit/mips32/Assembler-mips32.h"

nit: Add a newline above this one, to separate the header which is associated with this file from all other headers.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4da0532d8f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e4da0532d8f