Closed
Bug 1204195
Opened 9 years ago
Closed 9 years ago
Fix two warnings in dom/media/webaudio/blink/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
2.36 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
They were both "truncation from 'double' to 'float'" warnings. This also allows the COMPILER_ALLOW_WARNINGS=True flag to be removed.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8660257 -
Flags: review?(giles)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Try server looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ca0667bea98
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8660257 [details] [diff] [review] Fix two warnings in dom/media/webaudio/blink/ Review of attachment 8660257 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable to me. Thanks for the cleanup!
Attachment #8660257 -
Flags: review?(giles) → review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a748cf7b0c31
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•