Closed Bug 1204214 Opened 4 years ago Closed 4 years ago

IonMonkey: MIPS: Split shareable code to mips-shared in BaselineCompiler-mips32

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(1 file)

Bug 1194139, part 9: BaselineCompiler-mips.
Attachment #8660284 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8660284 [details] [diff] [review]
BaselineCompiler-mips.patch

Review of attachment 8660284 [details] [diff] [review]:
-----------------------------------------------------------------

jandem: What is the point of having these BaselineCompiler-<arch>.h files, if they are empty?

::: js/src/jit/mips-shared/BaselineCompiler-mips-shared.cpp
@@ +13,1 @@
>                                             JSScript* script)

nit: align properly.
Attachment #8660284 - Flags: review?(nicolas.b.pierron)
Attachment #8660284 - Flags: review+
Attachment #8660284 - Flags: feedback?(jdemooij)
https://hg.mozilla.org/mozilla-central/rev/e7c0433c8dbe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8660284 [details] [diff] [review]
BaselineCompiler-mips.patch

Review of attachment 8660284 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Nicolas B. Pierron [:nbp] from comment #1)
> jandem: What is the point of having these BaselineCompiler-<arch>.h files,
> if they are empty?

Ah yes we should remove them :)
Attachment #8660284 - Flags: feedback?(jdemooij) → feedback+
You need to log in before you can comment on or make changes to this bug.