120422 - Leaks on Brad tbox went up ~1KB, CSSImportantRule?

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Chris McAfee]

Leaks on Brad tbox went up, CSSImportantRule?
dbaron points at garrett, over to him for a look.

Comment 1

[Garrett Arch Blythe]

note, circa 1K (1024 bytes) will attempt to fix.

Comment 2

[Chris McAfee]

right, rpotts big leak stuff was hiding new leak creep numbers for about 36 hours.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think this is showing up as a leak because you do |delete mImportantRule| when
mImportantRule is a refcounted object (in nsCSSStyleRule.cpp), and you should
NS_RELEASE instead.

Comment 4

[Garrett Arch Blythe]

Here are my steps:

From mozilla/dist/bin, I do:

./mozilla -f bloaturls.txt --trace-malloc=tm.log
./run-mozilla.sh ./leakstats tm.log

And I get:
Leaks: 1181609 bytes, 17924 allocations
Maximum Heap Size: 7937132 bytes
48286522 bytes were allocated in 393852 allocations.


Now, this is just a build with no modifications that I recently pulled (last
night).  I tried this a few days back with the same results.

__How__ can brad tbox report 1k of leaks (well, 303kb today), while I get 1M of
leaks?

In any event, dbaron is totally right, I should be NS_RELEASEing regardless of
the leak reproducability.

Patching coming....

Comment 5

[Garrett Arch Blythe]

Attachment: NS_RELEASE instead of delete.

Request for r= sr=

Comment 6

[Garrett Arch Blythe]

adding hyatt in hopes of the sr= for patch.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 66171 [details] [diff] [review]
NS_RELEASE instead of delete.

r=dbaron.

It's the old-style leak stats that went up.  See
http://mozilla.org/performance/leak-brownbag.html#tbox

Comment 8

[Garrett Arch Blythe]

Comment on attachment 66171 [details] [diff] [review]
NS_RELEASE instead of delete.

rs=hyatt

Comment 9

[Mike Shaver (:shaver emeritus)]

Comment on attachment 66171 [details] [diff] [review]
NS_RELEASE instead of delete.

a=shaver on behalf of [e-mail].  (Also marking r/sr in the patch
manager on behalf of dbaron and hyatt.)

Comment 10

[Garrett Arch Blythe]

checked in on trunk and branch.