Enable/Disable Address Book commands when a Directory is selected

VERIFIED FIXED in mozilla0.9.9

Status

MailNews Core
LDAP Integration
P1
normal
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: scottputterman, Assigned: Srilatha Moturi)

Tracking

Trunk
mozilla0.9.9
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: nab-ldap)

Attachments

(1 attachment, 6 obsolete attachments)

(Reporter)

Description

17 years ago
We need to handle command updating for directories when they are selected in the
Address Book.  This can stand for that general bug.  When this gets checked in
we can file bugs for whatever remians.
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1+
Priority: -- → P1
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 1

17 years ago
Created attachment 66508 [details] [diff] [review]
patch to disable edit card fields

This patch will disable all the fields in the edit card dialog.
(Assignee)

Comment 2

17 years ago
Additional things that needs to be done:

1)Either disable New AddressBook card menu item and New Card button in the 
toolbar or In the New Card Dialog do not show LDAP directory in the dropdown 
list.

2)We need to do the same thing for New Mailing List

I think not showing LDAP directory in the drop down list is better.
Jennifer, Seth what's your take on this.
(Assignee)

Comment 3

17 years ago
one more thing. Need to bring up Directory Server Properties dialog when the 
user double clicks on ldap directory or when the user clicks on Properties 
dialog.
(Assignee)

Comment 4

17 years ago
Created attachment 66540 [details] [diff] [review]
patch to enable properties

With this patch the Directory server properties dialog comes up.
(Assignee)

Updated

17 years ago
Attachment #66540 - Attachment is obsolete: true
(Assignee)

Comment 5

17 years ago
Created attachment 66545 [details] [diff] [review]
patch to enable properties

The previous patch had a typo in it
(Assignee)

Comment 6

17 years ago
Created attachment 67188 [details] [diff] [review]
patch v1

With this patch 
1) The edit card fields are diable for LDAP
2) Clicking on the properties button brings up Directory Serve properties
dialog when and LDAP directory is selected
3) LDAP directory is not displayed in the list of directories in New Card
dialog
4) LDAP directory is not displayed in the list of directories in New Mailing
List Dialog
Attachment #66508 - Attachment is obsolete: true
Attachment #66545 - Attachment is obsolete: true

Comment 7

17 years ago
>I think not showing LDAP directory in the drop down list is better.
>Jennifer, Seth what's your take on this.

4.x allowed "New Card" and "New List" if an LDAP Dir was selected. The dialog 
opened with the first local AB selected by default. Only local ABs are available 
in dropdown list. This seems fine to me.

Comment 8

17 years ago
Comment on attachment 67188 [details] [diff] [review]
patch v1

r=bhuvan
Attachment #67188 - Flags: review+
(Assignee)

Comment 9

17 years ago
Filed a bug for Inst Msg tab
bugscape bug 12041.
Whiteboard: nab-ldap
Comment on attachment 67188 [details] [diff] [review]
patch v1

>-    if ("selectedAB" in window.arguments[0]) {
>+    if ("selectedAB" in window.arguments[0] && window.arguments[0].selectedAB) {

forgive my ignorance.  Is that change necessary because we're setting
selectedAB to ""?
why are we doing that?

everything else looks good.  sr=sspitzer
Attachment #67188 - Flags: superreview+
(Assignee)

Comment 11

17 years ago
Created attachment 68365 [details] [diff] [review]
patch v2

Changes from the previous patch.
Changed mailOverlay.xul so that we do not pass in selectedAB as 0
Changed abCarOverlay.xul,
so that we do not check window.arguments[0].selectedAB is ""
and also initialized editCard.selectedAB to "" to avoid getting a Javascript
strict warning if selectedAB is not passed in as one of the arguments to the
window. I'm getting the warning here 
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/abCardOverlay.js#101
(Assignee)

Updated

17 years ago
Attachment #68365 - Attachment is obsolete: true
(Assignee)

Comment 12

17 years ago
Created attachment 68368 [details] [diff] [review]
the right patch

Had some extra makefile.win changes in the previous patch so posting a new one.
(Assignee)

Comment 13

17 years ago
Created attachment 68381 [details] [diff] [review]
final patch

changed the the name goNewCardDialog() to openNewCardDialog()in mailOverlay.xul
since there is goNewCardDialog is defined in abCommon.js and mailOverlay.xul
Seth, thanks for pointing this out.
Attachment #67188 - Attachment is obsolete: true
Attachment #68368 - Attachment is obsolete: true
Comment on attachment 68381 [details] [diff] [review]
final patch

sr=sspitzer

nice work, srilatha.
Attachment #68381 - Flags: superreview+
(Assignee)

Comment 15

17 years ago
Fix checked in 
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
does this include the delete command (when the ab results pane has focus) or is 
that another bug?

I think that command is still enabled (it should be when the LDAP addressbook 
is focused in the dir tree, but not when an LDAP card is selected and has focus 
in the results pane.)

I'll log a bug, either way.
never mind, this is covered by bug #118262

Comment 18

17 years ago
2002022503 builds on all platforms.
Verified working well.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.