1204247 - Remove code supporting metro under testing/

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Bug 1039866 got most of it out of m-c, there's further to go in mochitest (and a bit in mozbase and mozharness).

https://dxr.mozilla.org/mozilla-central/search?q=path%3Atesting+metro

for a start, and anything mentioning immersiveMode.

Comment 1

[prateeksurana3255]

I want to work on this issue how can I get started?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure, here are the documentations:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 3

[Manish [:manishkk]]

:sylvestre 

What to do exactly in this? 

Need to remove all these lines?
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atesting+metro

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Most of them, yes!

Comment 5

[manank321]

If no one is assigned on this work. I would like to work on this issue.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Sure, I will assign it to the first person who reported a good first patch!

Comment 7

[manank321]

OkayThanks

Comment 8

[JJ]

Hi, 
I have never contributed to an Open Source before, but willing to be a part of it. Can anyone please help me, where do I work, and how do I start ? I did read a few documentations but still haven't been able to figure things out. 
Also, I don't seem to find any bugs to work on. I am trying to do something in python but looks like all bugs are assigned. What do I do ?
Thank you,

Comment 9

[Manish [:manishkk]]

Try IRC, #Introduction channel.

also look for 'Good-First-Bug'

(In reply to JJ from comment #8)
> Hi, 
> I have never contributed to an Open Source before, but willing to be a part
> of it. Can anyone please help me, where do I work, and how do I start ? I
> did read a few documentations but still haven't been able to figure things
> out. 
> Also, I don't seem to find any bugs to work on. I am trying to do something
> in python but looks like all bugs are assigned. What do I do ?
> Thank you,

Comment 10

[ronghui19]

im new to here. how do i get started to fix bug? i have checked doc and i still have no clue.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

See comment #2

Comment 12

[Devika Sugathan]

Hi
I would like to work on this bug! Could you please point me in the right direction of how to start.

Comment 13

[Manish [:manishkk]]

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction and https://whatcanidoformozilla.org/#!/progornoprog/proglang/py will help.

do you know metro? -  https://en.wikipedia.org/wiki/Metro_(design_language)

https://dxr.mozilla.org/mozilla-central/search?q=path%3Atesting+metro
if the code there looks like handling metro-specific thing, it needs to be removed.

Also for the  quick guidance ask your queries in IRC #Introduction

(In reply to Devika Sugathan from comment #12)
> Hi
> I would like to work on this bug! Could you please point me in the right
> direction of how to start.

Comment 15

[Devika Sugathan]

Attachment: New.patch

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Could you please use phabricator?

By the way, you don't want to do this change:

 suggested_reviewers:
-  - metromoxie

This isn't about Windows Metro

Comment 17

[Devika Sugathan]

Attachment: Updated.patch

Sorry, I had faced an error while using phabricator. Can I submit the patch here?

Comment 18

[Sylvestre Ledru [:Sylvestre]]

What was the error you had with phabricator?

Comment 19

[Dan Minor [:dminor]]

Comment on attachment 9007132 [details] [diff] [review]
Updated.patch

Review of attachment 9007132 [details] [diff] [review]:
-----------------------------------------------------------------

This seems reasonable to me, but it's been a while since I've really looked at the testing code. Redirecting to :jmaher :)

Comment 20

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9007132 [details] [diff] [review]
Updated.patch

Review of attachment 9007132 [details] [diff] [review]:
-----------------------------------------------------------------

I am fine using splinter, but please make sure you test your changes- I do not see how |./mach mochitest| will run, let alone the sunspider test in talos now.  I look forward to a cleaned up patch!

::: testing/mochitest/mochitest_options.py
@@ +791,4 @@
>          if options.immersiveMode:
>              if not mozinfo.isWin:
>                  parser.error("immersive is only supported on Windows 8 and up.")
> +            

nit: you have a blank line with whitespace here, please remove the whitespace

::: testing/mochitest/runtests.py
@@ +894,1 @@
>          self.browserProcessId = None

we removed the comment, do we need browserProcessId?  I would recommend searching for uses of this and looking at the history in case other scenarios use it.

@@ +1077,3 @@
>              self.testRoot = options.flavor
>  
>              if options.flavor == 'browser' and options.immersiveMode:

please remove the if statement, this is invalid syntax.

@@ +2935,4 @@
>              self.lsanLeaks = lsanLeaks
>              self.bisectChunk = bisectChunk
>  
> +            

nit: another line with just whitespace.

@@ +2939,1 @@
>              # output which we need to pick up on and parse out. This variable tracks the real

removing 2 lines doesn't necessarily work here- the comment is not useful.  In fact, this leads up to the question do we need browserProcessId?

::: testing/talos/talos/tests/dromaeo/tests/sunspider-string-tagcloud.html
@@ +24,4 @@
>   * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>   * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>   * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

please do not change anything in this file- there is reference to the 5 characters 'metro' in here, but it is part of a larger word and this is a specific benchmark.

Comment 21

[William Strode]

Hi,

Is there still more work to be done on this? I'd be happy to take a look at finishing it up if so.

Thanks!

Comment 22

[Divyansh Sharma [:spiro]]

Attachment: Bug 1204247: Remove code supporting metro under testing/

Bug 1204247: Remove code supporting metro under testing/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06f16a4668c
Remove code supporting metro under testing/ r=jmaher

Comment 24

[Divyansh Sharma [:spiro]]

Hi Joel.

What's the status of my diff?

Comment 25

[Joel Maher ( :jmaher ) (UTC -8)]

this has been landed- we are waiting for it the merge to mainline mozilla-central branch which usually happens twice/day, I think in the next 3-4 hours.

Comment 26

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c06f16a4668c