Closed Bug 1204288 Opened 5 years ago Closed 5 years ago

Autophone - do not short circuit test downloads based on existence of tests directory

Categories

(Testing :: Autophone, defect)

Product:
Testing
Component:
Autophone
Type:
defect
Priority:
Not set

Tracking

(firefox43 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox43 --- affected

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

patch v1
10.58 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
Attached patch patch v1 — — Splinter Review 
Currently, builds.py checks if the tests subdirectory exists in the build directory to determine if the tests should be downloaded or not. If it does not exist, then all of the test packages which are required for the current job are downloaded and unpacked in the build's tests subdirectory. This can be a problem if a build is downloaded via trigger_runs.py for use with a specific test package (e.g. reftests), then later is downloaded again for a different test package (e.g. mochitests). In this scenario, builds.py will see that the tests directory exists and will not attempt to download the mochitests test package.

The following patch removes the check for the tests directoy and instead checks for the existence of each individual test package while also respecting the force parameter though it is not used anywhere at the moment. I tested this via try with

python trigger_runs.py --build-location=tinderbox --repo=try --build-url=http://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/bclary@mozilla.com-657a16829b91/try-android-api-9/ --test=autophone-crashtest-1

python trigger_runs.py --build-location=tinderbox --repo=try --build-url=http://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/bclary@mozilla.com-657a16829b91/try-android-api-9/ --test=autophone-robocoptest-autophone

You can see before and after patch runs at https://treeherder.allizom.org/#/jobs?repo=try&revision=657a16829b91

Found this testing the different try options from the deployment in bug 1204092.
Attachment #8660389 - Flags: review?(gbrown)
Comment on attachment 8660389 [details] [diff] [review]
patch v1

Review of attachment 8660389 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!
Attachment #8660389 - Flags: review?(gbrown) → review+
https://github.com/mozilla/autophone/commit/bd00ca865ec1445be56f69981bc8647fbb556ef9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.