1204303 - error while adding results result in a "Graph server unreachable" error

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

For example in the log http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ba38bdc52e1d/try-win32/try_win7-ix_test-tp5o-bm112-tests1-windows-build505.txt.gz, we can see the following stack trace:

> 01:37:12    ERROR -  Traceback (most recent call last):
> 01:37:12     INFO -    File "C:\slave\test\build\tests\talos\talos\ttest.py", line 246, in _runTest
> 01:37:12     INFO -      else None))
> 01:37:12     INFO -    File "C:\slave\test\build\tests\talos\talos\results.py", line 121, in add
> 01:37:12     INFO -      global_counters=self.global_counters
> 01:37:12     INFO -    File "C:\slave\test\build\tests\talos\talos\results.py", line 343, in __init__
> 01:37:12     INFO -      self.error(match.group(1))
> 01:37:12     INFO -    File "C:\slave\test\build\tests\talos\talos\results.py", line 357, in error
> 01:37:12     INFO -      raise utils.TalosError(message)
> 01:37:12     INFO -  TalosError: Timeout in tp5n

But in treeherder (https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba38bdc52e1d) this is reported as a Graph server unreachable error, thus probably going in the associated intermittent bug.
But the real issue is not at all a graph server unreachable error, so we should fix that - that would allow us in a first time to record those failures in an appropriate bug, and will help us later to fix the real issue.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1204303 - error while adding results result in a "Graph server unreachable" error. r=jmaher

Bug 1204303 - error while adding results result in a "Graph server unreachable" error. r=jmaher

This will raise the real error when adding test results instead of swallowing it.

Also, I removed an obsolete example conf file (in yaml, but we dropped that support) and
removed the stamped_msg function, replacing that with raw logging calls.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8660403 [details]
MozReview Request: Bug 1204303 - error while adding results result in a "Graph server unreachable" error. r=jmaher

https://reviewboard.mozilla.org/r/19125/#review16969

this is great cleanup!

Comment 3

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5613447f31db

Comment 4

[Julien Pagès (:parkouss)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5feaf142d663053e501f9e03731e88c973f05318
Bug 1204303 - error while adding results result in a "Graph server unreachable" error. r=jmaher

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5feaf142d663