Closed Bug 1204421 Opened 10 years ago Closed 10 years ago

Layout issues in “Sign in” pop-up window

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

Product:
Cloud Services
Component:
Server: Firefox Accounts
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: vvalentina, Assigned: stomlinson)

References

(
URL
)

Details

Steps to reproduce: 1. Load MP-stage page https://marketplace.allizom.org/ 2. Sign in Expected results: The login pop-up window appears. There are no display or layout issues. Actual results: The login pop-up window has layout issues. Notes/Issues: Register page has also layout issues. Issue can be seen on mobile too. Verified on FF43(Win 7). Issue is reproduced on MP-stage, dev and production. Please see the screenshot: http://screencast.com/t/wp3W7XfZQ1
Component: Consumer Pages → FxAccounts
Product: Marketplace → Core
Target Milestone: 2015-09-15 → ---
Version: Avenir → unspecified
It seems that some UI refresh work in FxA has changed the width of the content in the pop. Some more discussion in [1], but I wonder if the simplest fix might be for marketplace to make the popup a little wider by default. Chuck, let me know whether and how urgently you need us to dig into the details on the FxA side. [1] https://github.com/mozilla/fxa-content-server/issues/3065
Component: FxAccounts → Server: Firefox Accounts
Flags: needinfo?(charmston)
Product: Core → Cloud Services
Assignee: nobody → stomlinson
I don't think it's too urgent, although it seems that setting this width declaration to max-width addresses the issue: https://github.com/mozilla/fxa-content-server/blob/a3559e5b560cb7b8c73b8e900576b7ccdeb615c9/app/styles/_layout.scss#L9 Happy to file a PR if you agree. Ninja: heh, Shane beat me to it. Including comment for posterity.
Flags: needinfo?(charmston)
Status: NEW → ASSIGNED
The referenced PR has merged and is in production.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
The issue is still reproducing on MP-dev FF43(Win 7) Please see the screenshot: http://screencast.com/t/zfCekhcLMWb Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is actually working on production; it looks like Shane deployed changes there, but not on the FxA dev server. I think it's fine to test this bug on production.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Based on comment 6 I'll mark this bug as fixed. Postfix screenshot in MP-prod FF43(Win 7): http://screencast.com/t/7sYDQUtE Closing bug.
Status: RESOLVED → VERIFIED
Thanks for the help, Shane! Much appreciated.
You need to log in before you can comment on or make changes to this bug.