1204426 - SettingsServiceLock never removes message manager listeners

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I don't know how we never noticed this before, but bug 1183361 has a log with ~8800 SettingsServiceLocks and 77000 observers keeping them alive.  The message listeners that we add need to be either weak or removed.

Comment 1

[:gerard-majax]

(In reply to Kyle Huey [:khuey] ([e-mail]) (UTC+8 and delayed responses until 9/21) from comment #0)
> I don't know how we never noticed this before, but bug 1183361 has a log
> with ~8800 SettingsServiceLocks and 77000 observers keeping them alive.  The
> message listeners that we add need to be either weak or removed.

That seems strange. Can you check the values of "settings-service-locks/created" and "settings-service-locks/deleted" ? If we are leaking anything we should see it in about:memory with those two values being unbalanced.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

They're the same.  We're unregistering the locks.  They're just not actually being deleted because we don't remove those message listeners.

Comment 3

[:gerard-majax]

Attachment: Unregister message listeners of settings service locks

Comment 4

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb503a209c9b

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ee63977ebaa

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ee63977ebaa