Closed Bug 1204426 Opened 4 years ago Closed 4 years ago

SettingsServiceLock never removes message manager listeners

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
FxOS-S7 (18Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: khuey, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

I don't know how we never noticed this before, but bug 1183361 has a log with ~8800 SettingsServiceLocks and 77000 observers keeping them alive.  The message listeners that we add need to be either weak or removed.
Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(kyle)
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) (UTC+8 and delayed responses until 9/21) from comment #0)
> I don't know how we never noticed this before, but bug 1183361 has a log
> with ~8800 SettingsServiceLocks and 77000 observers keeping them alive.  The
> message listeners that we add need to be either weak or removed.

That seems strange. Can you check the values of "settings-service-locks/created" and "settings-service-locks/deleted" ? If we are leaking anything we should see it in about:memory with those two values being unbalanced.
Flags: needinfo?(lissyx+mozillians)
They're the same.  We're unregistering the locks.  They're just not actually being deleted because we don't remove those message listeners.
Assignee: nobody → lissyx+mozillians
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S7 (18Sep)
Flags: needinfo?(kyle)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ee63977ebaa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.