Closed Bug 1204441 Opened 4 years ago Closed 4 years ago

Increase vertical padding of dropmarker in a navbar menu-button on Windows 10

Categories

(Firefox :: Theme, defect)

Unspecified
Windows 10
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox40 --- wontfix
firefox41 --- wontfix
firefox42 --- verified
firefox43 --- verified

People

(Reporter: hectorz, Assigned: hectorz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Only that of #bookmarks-menu-button was updated with other buttons.
Bug 1204441 - Increase vertical padding of dropmarker in a navbar menu-button on Windows 10. r?jaws
Attachment #8660594 - Flags: review?(jaws)
Duplicate of this bug: 1202594
Blocks: theme-win10
Attachment #8660594 - Flags: review?(jaws) → review+
A try push is required before I can set checkin-needed, but I couldn't find any tests in browser/themes folder, what tests should I run here? Thanks.
Assignee: nobody → bzhao
We don't have any tests that cover the dropmarker. This change is fine for checkin-needed.
Status: NEW → ASSIGNED
Keywords: checkin-needed
(In reply to (Mostly away 9/11-9/23) Jared Wein [:jaws] (please needinfo? me) from comment #4)
> We don't have any tests that cover the dropmarker. This change is fine for
> checkin-needed.

Thank you, Jared, and sorry for not noticing you're away earlier.

Note to sheriff: I wrote "r?jaws" in the commit message but this was actually given r+ by :dao.
That's fine, no worries. Thanks for fixing this bug! :)
I updated the commit message to r=dao before landing. Thanks for mentioning in the bug :)
https://hg.mozilla.org/mozilla-central/rev/844a70e85eba
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment on attachment 8660594 [details]
MozReview Request: Bug 1204441 - Increase vertical padding of dropmarker in a navbar menu-button on Windows 10. r?jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1179295 / windows 10
[User impact if declined]: see bug 1202594
[Describe test coverage new/current, TreeHerder]: landed in m-c for more than a week
[Risks and why]: simple css changes, low risk
[String/UUID change made/needed]: none
Attachment #8660594 - Flags: approval-mozilla-beta?
Comment on attachment 8660594 [details]
MozReview Request: Bug 1204441 - Increase vertical padding of dropmarker in a navbar menu-button on Windows 10. r?jaws

Polish for windows 10, should be safe, taking it.
Attachment #8660594 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Reproduced the initial issue on Windows 10 32bit using Firefox 41.0.1 build 2.

Confirming the fix on:
- latest Aurora, build ID 20150930004021
- Firefox 42 beta 2, build ID 20150928102225.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.