1204443 - Add CONTRIBUTING.md file to repository for information how to contribute

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Similar to mozdownload we should add such a file to our firefox-ui-tests repository. It will help contributors and others to do the right steps in creating patches, reviewing, and merging PR's.

https://github.com/mozilla/mozdownload/blob/master/CONTRIBUTING.md

Comment 1

[Barbara Miller (:galgeek)]

Attachment: github pull request

I've pushed up a lightly edited copy from the mozdownload repo.

I wonder whether the "Versioning" section applies at all to this repo.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8678675 [details] [review]
github pull request

Looks fine. Comments made on the PR itself.

Comment 3

[Barbara Miller (:galgeek)]

Comment on attachment 8678675 [details] [review]
github pull request

Thanks for your feedback, Henrik! I've updated the PR.

Travis runs shouldn't be affected by addition of .md file... however, Mac OS X runs are failing in mozdownload.

Comment 4

[Barbara Miller (:galgeek)]

Thanks for today's feedback, Henrik!

I've updated the PR. 

There's a failure of one of the windows tests there's been trouble with on Travis, but that again should be entirely unrelated to this documentation update.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8678675 [details] [review]
github pull request

Looks perfect now. Thanks Barbara! It will certainly help others to get started. I will land the PR in a moment.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged PR to mozilla-central as:
https://github.com/mozilla/firefox-ui-tests/commit/0611db24ee27724405160426c37b1fb515d9d8a5