1204481 - Reset Network panel filter for requests linked from console

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Zartner [:sebo]]

When somebody clicks on a network request within the Console panel, the display switches to the Network panel since bug 861335 to show the request details there.

Though if the Network panel has a filter set and the clicked request does not match the filter, the request details are not displayed.

Example:
You have 'JS' set as filter within the Network panel. Within the Console panel you click on a CSS resource.

=> The display switches to the Network panel, though in there nothing happens.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

Btw. the filter may just be reset in case the resource doesn't match the currently set filter.

Also, there may be a notification when the filter is reset.

Sebastian

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

I have a fix for this.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Reset the network panel filter for requests linked from the console (bug 1204481).

Comment 5

[Sebastian Zartner [:sebo]]

So it looks like you decided to always reset the filter. What speaks against the solution in comment 1?

Sebastian

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Now with a test.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v3

(In reply to Sebastian Zartner [:sebo] from comment #5)
> So it looks like you decided to always reset the filter. What speaks against
> the solution in comment 1?

Sorry, I didn't see your comment yesterday. That behavior was already there from the previous iterations of the patch, but I agree that only resetting it when absolutely necessary is preferable. Here is an updated version that does just that.

Comment 8

[Victor Porof [:vporof][:vp]]

Comment on attachment 8661080 [details] [diff] [review]
Patch v3

Review of attachment 8661080 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-controller.js
@@ +339,5 @@
>        let predicate = i => i.value === requestId;
>        request = NetMonitorView.RequestsMenu.getItemForPredicate(predicate);
> +      if (!request) {
> +        // Reset filters so that the request is visible.
> +        NetMonitorView.RequestsMenu.filterOn("all");

Why not just always do this? Just curious.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof [:vporof][:vp] from comment #8)
> Why not just always do this? Just curious.

Having to continuously adjust the netmonitor filter back to, say JS, after going to the console and back, will surely start taking its toll on someone only interested in JS files.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3c30e2768d9d

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c30e2768d9d

Comment 12

[Sebastian Zartner [:sebo]]

Works fine for me now. Thank you very much, Panos!

Sebastian