1204492 - Add strings/l10n translations for pbmode

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Bug for getting all of the needed strings and translations in for Private Browsing.

Comment 1

[Darrin Henein [:darrin]]

I think we need 5 strings:

**Empty private browsing tab tray**

[1] title: "Private Browsing"
[2] body: "Firefox won’t remember any of your history or cookies, but new bookmarks will be saved."

**Settings**
[3] "Close private tabs" > [4] "When leaving private browsing" / [5] "Manually" (default) 

(see Settings > Safari > Open Links setting in iOS for the settings style to use here)

Comment 2

[Aaron Train [:aaronmt]]

Should there be a similar learn more link found on desktop/android?

Comment 3

[Darrin Henein [:darrin]]

Great point Aaron... do we have such a page (or is the desktop/android one general enough... which I doubt)?

Comment 4

[Karen Rudnitski [:kar]]

The 'learn more' link points to a sumo article talking about PB on android. No reason we couldn't point to an iOS sumo page relating to PB?

Comment 5

[Stephan Leroux [:sleroux]]

Added another dependency - we probably need 'Open In New Private Tab' when triggering the long press context menu within a private tab. Right now we show 'Open In New Tab'.

Comment 6

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1081

Remaining strings needed for private browsing

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

If these strings are for the settings, do we need Camel Caps Casing For These Strings?

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Darrin Henein [:darrin] from comment #1)
> **Settings**
> [3] "Close private tabs" > [4] "When leaving private browsing" / [5]
> "Manually" (default) 
> 
> (see Settings > Safari > Open Links setting in iOS for the settings style to
> use here)

I need a bit of help to understand how this works: the first level setting will be "Close private tabs", you tap and get "When leaving private browsing", you tap again and get a selection between "Manually" and "Automatically".

For Safari the option value is displayed near "Open Links", do you plan to display it near "Close private tabs"? With "Automatically" it will barely fit for English, probably won't for several locales.

Comment 9

[Darrin Henein [:darrin]]

Sorry, to clarify:

Top-level setting is "Close Private Tabs", which gives you two options: "When Leaving Private Browsing" (which is 'automatically') or "Manually"

Comment 10

[Darrin Henein [:darrin]]

Stephan, re :flod's comment "For Safari the option value is displayed near "Open Links", do you plan to display it near "Close private tabs"? With "Automatically" it will barely fit for English, probably won't for several locales."

Can we show "Manually"/"Automatically" as the string on the right side/subtitle on the main screen, but tapping in gives you more verbose options? Or maybe we go with "Automatically" and "Manually" with a subtitle on the Automatically row which says "When Leaving Private Browsing"?

I cam provide wireframes if this isn't clear.

Comment 11

[Stephan Leroux [:sleroux]]

Either option works. Just to clarify:

Option 1: [Close Private Tabs          Automatically] -> [When Leaving Private Browsing] -> [Manually]/[Automatically[

Option 2: 
[Close Private Tabs] -> [Automatically \n when leaving private browsing] -> [Manually]/[Automatically]

(Sorry for my ASCII art)

Comment 12

[Darrin Henein [:darrin]]

Attachment: Screen Shot 2015-09-17 at 3.43.35 PM.png

As per IRC, let's go with this.

Comment 13

[Francesco Lodolo [:flod]]

Comment on attachment 8662549 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1081

Left a couple of comments in the PR, f+ with those addressed.

In particular, we shouldn't pre-land strings if we're not planning to use them, which seems the case for "Automatically" and "Manually".

Comment 14

[Stephan Leroux [:sleroux]]

Merged