AVRCP improvements in Gecko

RESOLVED FIXED in Firefox 44

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
FxOS-S8 (02Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(2 attachments)

This bug report is for reviewing AVRCP improvements of bug 1202060.
Fixes a bug in the AVRCP IPC code.
Attachment #8660735 - Flags: review?(shuang)
Cosmetic fix to make AVRCP connects/disconnects look similar to the other managers.
Attachment #8660736 - Flags: review?(shuang)
Verified using BlueZ 5.33 as AVRCP Controller role.

09-21 04:25:28.540 D/bt-btif ( 6272): handle_rc_features: rc_features=0x5       
09-21 04:25:28.540 I/bt-btif ( 6272): HAL bt_rc_callbacks->remote_features_cb

Breakpoint 1, mozilla::dom::bluetooth::BluetoothAvrcpManager::RemoteFeatureNotification (this=<optimized out>, aBdAddr=..., aFeatures=5)
    at ../../../../../b2g-inbound/b2g-inbound/dom/bluetooth/bluedroid/BluetoothAvrcpManager.cpp:804
804       BT_LOGR("AVRCP remote features: %d", (int) aFeatures);
(gdb) p aFeatures
$2 = 5
Comment on attachment 8660735 [details] [diff] [review]
[01] Bug 1204497: Interpret AVRCP remote features as bitmask

Review of attachment 8660735 [details] [diff] [review]:
-----------------------------------------------------------------

I tried to use BlueZ 5.34 on laptop as avrcp controller to verify AVRCP 1.4 remote features notification and it looks good to me.
Steps as the following:
1. Run bluetoothctl and connect to b2g phone
2. After avrcp connected and check the status
Additional notice: Now run "bluetooth-player" using BlueZ 5, it is possible to use it test play/pause/stop/rewind/fastfwd/next/previous track, also metadata is possible.

Thanks for fixing it.
Attachment #8660735 - Flags: review?(shuang) → review+
https://hg.mozilla.org/mozilla-central/rev/cea992dbc031
https://hg.mozilla.org/mozilla-central/rev/abd2dfe8eaf1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.