1204497 - AVRCP improvements in Gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This bug report is for reviewing AVRCP improvements of bug 1202060.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1204497: Interpret AVRCP remote features as bitmask

Fixes a bug in the AVRCP IPC code.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1204497: Complete AVRCP connect/disconnect from separate runnables

Cosmetic fix to make AVRCP connects/disconnects look similar to the other managers.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Verified using BlueZ 5.33 as AVRCP Controller role.

09-21 04:25:28.540 D/bt-btif ( 6272): handle_rc_features: rc_features=0x5       
09-21 04:25:28.540 I/bt-btif ( 6272): HAL bt_rc_callbacks->remote_features_cb

Breakpoint 1, mozilla::dom::bluetooth::BluetoothAvrcpManager::RemoteFeatureNotification (this=<optimized out>, aBdAddr=..., aFeatures=5)
    at ../../../../../b2g-inbound/b2g-inbound/dom/bluetooth/bluedroid/BluetoothAvrcpManager.cpp:804
804       BT_LOGR("AVRCP remote features: %d", (int) aFeatures);
(gdb) p aFeatures
$2 = 5

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8660735 [details] [diff] [review]
[01] Bug 1204497: Interpret AVRCP remote features as bitmask

Review of attachment 8660735 [details] [diff] [review]:
-----------------------------------------------------------------

I tried to use BlueZ 5.34 on laptop as avrcp controller to verify AVRCP 1.4 remote features notification and it looks good to me.
Steps as the following:
1. Run bluetoothctl and connect to b2g phone
2. After avrcp connected and check the status
Additional notice: Now run "bluetooth-player" using BlueZ 5, it is possible to use it test play/pause/stop/rewind/fastfwd/next/previous track, also metadata is possible.

Thanks for fixing it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/cea992dbc031
https://hg.mozilla.org/integration/b2g-inbound/rev/abd2dfe8eaf1

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=abd2dfe8eaf1

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cea992dbc031
https://hg.mozilla.org/mozilla-central/rev/abd2dfe8eaf1