Closed Bug 1204529 Opened 4 years ago Closed 4 years ago

mMaxTimePerPollIter should be atomic

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: dragana, Assigned: dragana)

Details

Attachments

(1 file, 2 obsolete files)

mMaxTimePerPollIter should be atomic: it is written on the main thread but read on socketThread.
Attached patch bug_1204529.patch (obsolete) — Splinter Review
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attachment #8660773 - Flags: review?(mcmanus)
Comment on attachment 8660773 [details] [diff] [review]
bug_1204529.patch

Review of attachment 8660773 [details] [diff] [review]:
-----------------------------------------------------------------

relaxed is the right semantic here.. thanks!
Attachment #8660773 - Flags: review?(mcmanus) → review+
Attached patch bug_1204529.patch (obsolete) — Splinter Review
rebased
Attachment #8660773 - Attachment is obsolete: true
Attachment #8661756 - Flags: review+
Keywords: checkin-needed
commit msg changed
Attachment #8661756 - Attachment is obsolete: true
Attachment #8661906 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d9337a944fae
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.