Closed Bug 1204535 Opened 4 years ago Closed 4 years ago

Refactor computation of mShouldBuildScrollableLayer

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(6 files)

While looking at how to fix bug 1195431 I noticed that the code to compute mShouldBuildScrollableLayer is very convoluted. There's a number of other cleanups that can be done around that code as well, so I'm filing this bug for it.
Well the refactoring didn't end up quite where I wanted but there's some patches which I think are good to land. Try push for them is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=df1a8fe4247c
This makes the refactoring in part 3 more obvious.
Attachment #8661178 - Flags: review?(tnikkel)
At whistler we did a grep and found more usages of "displayPort" than "displayport" and decided to move towards that. This function has both usingDisplayport and usingDisplayPort which could get confusing, so using the same name is a good idea.
Attachment #8661180 - Flags: review?(tnikkel)
Attachment #8661177 - Flags: review?(tnikkel) → review+
Attachment #8661178 - Flags: review?(tnikkel) → review+
Attachment #8661179 - Flags: review?(tnikkel) → review+
Attachment #8661180 - Flags: review?(tnikkel) → review+
Attachment #8661181 - Flags: review?(tnikkel) → review+
Attachment #8661182 - Flags: review?(tnikkel) → review+
Thanks. I had patches to do most of this as part of an even larger refactor (that didn't get finished).
Thanks for the speedy reviews! I hope these patches don't cause you too much rebase pain on the rest of the refactoring you had.
You need to log in before you can comment on or make changes to this bug.