1204570 - Visual / ux refresh for the Beta -> Dev Edition promo doorhanger

Status: RESOLVED WONTFIX

(DevTools :: General, defect, P3)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

See bug 1078539

When we look at the dev edition doorhanger currently used in Beta we see two things:

1. it's successful
2. it could be better

This bug should track improving the doorhanger with an aim to getting it enabled on release channel as well.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: beta-doorhanger.png

Screenshot - notice that the doorhanger is dark regardless of the toolbox theme (which is light by default in beta)

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Adding some priority to a first set of bugs. :)

Comment 3

[Brian Grinstead [:bgrins]]

I believe devtools.devedition.promo.enabled needs to be true and devtools.devedition.promo.shown needs to be false to show the promo: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/doorhanger.js#17-18

Comment 4

[Brian Grinstead [:bgrins]]

Although interestingly when I set those prefs in Dev Edition 42 and open the toolbox I see this error:

A coding exception was thrown and uncaught in a Task.

Full message: TypeError: Promise is undefined
Full stack: wait@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/doorhanger.js:157:7
exports.showDoorhanger<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/doorhanger.js:85:9
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
Toolbox.prototype._showDevEditionPromo@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1995:5

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

Created some mockups for this here: http://helenvholmes.com/devtools-ux/doorhanger/

Also created a meeting for next week to go over building it as an add-on and testing it.

Comment 6

[Patrick Brosset <:pbro>]

Triaging. This was added as a P1 7 months ago, but I don't think this is a priority anymore. Returning to the backlog.