1204594 - Make use of MOZ_RAII and ScopeExit to simplify some Auto guards in the GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: use_MOZ_RAII-v0.diff

8 files changed, 33 insertions(+), 80 deletions(-)

Comment 1

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26e53e242a9

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8660853 [details] [diff] [review]
use_MOZ_RAII-v0.diff

Review of attachment 8660853 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ I hated that ugly thing.

We don't need to include anything to get the definition, though?

::: js/src/gc/Marking.cpp
@@ -1249,5 @@
>  {
>  #ifdef DEBUG
> -    struct AutoCheckCompartment {
> -        bool& flag;
> -        explicit AutoCheckCompartment(bool& comparmentCheckFlag) : flag(comparmentCheckFlag) {

-1 typo here too

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Steve Fink [:sfink, :s:] from comment #2)
> Comment on attachment 8660853 [details] [diff] [review]
> use_MOZ_RAII-v0.diff
> 
> Review of attachment 8660853 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> \o/ I hated that ugly thing.
> 
> We don't need to include anything to get the definition, though?

As in, shouldn't this patch have some #include <mfbt/Attributes.h> lines?

Comment 4

[Steve Fink [:sfink] [:s:]]

Er... that would be mozilla/Attributes.h, I think.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60fdd3ce9836

Comment 6

[Terrence Cole [:terrence]]

(In reply to Steve Fink [:sfink, :s:] from comment #4)
> Er... that would be mozilla/Attributes.h, I think.

Apparently not? I think that js/HeapAPI.h has it, which means we get it "for free" everywhere. We /should/ stop smuggling it, but that's a bit of a fool's errand at this point.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60fdd3ce9836