Closed Bug 1204615 Opened 4 years ago Closed 4 years ago

Make toolbar button border and background more opaque for dark themes

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

patch
1.20 KB, patch
jaws
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Not sure how to explain this, but subjectively semitransparent white on a dark background seems fainter than black with the same transparency on a bright background. For instance we did the same in bug 1198703.
Attachment #8660875 - Flags: review?(jaws)
Attachment #8660875 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/e65a7ddaa9e0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
I have reproduced this bug on Nightly 43.0a1 (2015-09-14) on ubuntu 14.04 LTS, 32 bit!

Build ID: 20150914030205
User Agent: Mozilla/5.0 (X11; Linux i686; rv:43.0) Gecko/20100101 Firefox/43.0

The bug's fix is now verified on Latest Aurora 43.0a2(2015-10-11)!

Build ID: 20151011004016
User Agent: Mozilla/5.0 (X11; Linux i686; rv:43.0) Gecko/20100101 Firefox/43.0

[bugday-20151007]
Sorry, this bug only existed on Windows.
OS: Unspecified → Windows
You need to log in before you can comment on or make changes to this bug.