Closed Bug 1204624 Opened 4 years ago Closed 10 months ago

Don't override devedition dark theme toolbar button styling on Windows 10/8

Categories

(Firefox :: Theme, defect, P4)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: ntim, Unassigned)

References

Details

(Whiteboard: [devedition-polish])

Attachments

(1 file)

The vars set on #nav-bar[brighttext] for the toolbar buttons are overriding the devedition dark theme styling.
Theorically, those vars will also override the toolbar button style on Windows 7 and lower for dark lw-themes, but I haven't tested to confirm that.

Not sure if any of these effects are intented.
Summary: Don't use override devedition dark theme toolbar button styling on Windows 10/8 → Don't override devedition dark theme toolbar button styling on Windows 10/8
Brian, should we do something about this or can we just let the dark devtools theme use the default dark theme toolbar button style we have in place on Windows?
Flags: needinfo?(bgrinstead)
(In reply to Dão Gottwald [:dao] from comment #1)
> Brian, should we do something about this or can we just let the dark
> devtools theme use the default dark theme toolbar button style we have in
> place on Windows?

I think a screenshot would be helpful for comparison.  Forwarding question to Stephen.
Flags: needinfo?(bgrinstead) → needinfo?(shorlander)
Switching ni? to Helen.  Tim, can you please upload a screenshot of the issue?
Flags: needinfo?(shorlander)
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(hholmes)
Keywords: uiwanted
Priority: -- → P4
Attached image screenshot.png
Screenshot on Win 7
Flags: needinfo?(ntim.bugs)
So, for consistency's sake, I think it makes sense to use the dev edition button styling instead of the light weight theme styling since that's what we're doing on OSX and Linux. I'm going to add this as a polish bug.
Flags: needinfo?(hholmes)
Keywords: uiwanted
Whiteboard: [devedition-polish]
Blocks: 1331679
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.