1204624 - Don't override devedition dark theme toolbar button styling on Windows 10/8

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P4)

Description

[Tim Nguyen :ntim]

The vars set on #nav-bar[brighttext] for the toolbar buttons are overriding the devedition dark theme styling.
Theorically, those vars will also override the toolbar button style on Windows 7 and lower for dark lw-themes, but I haven't tested to confirm that.

Not sure if any of these effects are intented.

Comment 1

[Dão Gottwald [:dao]]

Brian, should we do something about this or can we just let the dark devtools theme use the default dark theme toolbar button style we have in place on Windows?

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Dão Gottwald [:dao] from comment #1)
> Brian, should we do something about this or can we just let the dark
> devtools theme use the default dark theme toolbar button style we have in
> place on Windows?

I think a screenshot would be helpful for comparison.  Forwarding question to Stephen.

Comment 3

[Brian Grinstead [:bgrins]]

Switching ni? to Helen.  Tim, can you please upload a screenshot of the issue?

Comment 4

[Tim Nguyen :ntim]

Attachment: screenshot.png

Screenshot on Win 7

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

So, for consistency's sake, I think it makes sense to use the dev edition button styling instead of the light weight theme styling since that's what we're doing on OSX and Linux. I'm going to add this as a polish bug.